Skip to content

Add --no-emit-find-links option (fixes #848) - #873

Merged
atugushev merged 2 commits into
jazzband:masterfrom
jacobtolar:no-emit-find-links
Aug 14, 2019
Merged

Add --no-emit-find-links option (fixes #848)#873
atugushev merged 2 commits into
jazzband:masterfrom
jacobtolar:no-emit-find-links

Conversation

@jacobtolar

@jacobtolar jacobtolar commented Aug 13, 2019 •
edited by atugushev
Loading

Copy link
Copy Markdown
Contributor

Fixes #848.

Changelog-friendly one-liner: Add new --no-emit-find-links option

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jacobtolar

jacobtolar commented Aug 13, 2019

Copy link
Copy Markdown
Contributor Author

weird; black passed for me locally:

$ tox -e checkqa
...
checkqa runtests: commands[0] | pre-commit run --all-files --show-diff-on-failure
black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed
bandit...................................................................Passed

Will push the suggested change anyways...

@codecov

codecov Bot commented Aug 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #873 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   99.05%   98.84%   -0.22%     
==========================================
  Files          35       35              
  Lines        2223     2160      -63     
  Branches      284      285       +1     
==========================================
- Hits         2202     2135      -67     
- Misses         13       15       +2     
- Partials        8       10       +2
Impacted Files Coverage Δ
tests/test_writer.py 100% <ø> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
piptools/writer.py 99.14% <100%> (+0.01%) ⬆️
piptools/repositories/pypi.py 92.55% <0%> (-2.27%) ⬇️
piptools/repositories/local.py 91.11% <0%> (-0.89%) ⬇️
tests/conftest.py 97.36% <0%> (-0.34%) ⬇️
piptools/scripts/sync.py 100% <0%> (ø) ⬆️
piptools/resolver.py 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903931f...d43445f. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Aug 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #873 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   99.05%   98.84%   -0.22%     
==========================================
  Files          35       35              
  Lines        2223     2160      -63     
  Branches      284      285       +1     
==========================================
- Hits         2202     2135      -67     
- Misses         13       15       +2     
- Partials        8       10       +2
Impacted Files Coverage Δ
tests/test_writer.py 100% <ø> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
piptools/writer.py 99.14% <100%> (+0.01%) ⬆️
piptools/repositories/pypi.py 92.55% <0%> (-2.27%) ⬇️
piptools/repositories/local.py 91.11% <0%> (-0.89%) ⬇️
tests/conftest.py 97.36% <0%> (-0.34%) ⬇️
piptools/scripts/sync.py 100% <0%> (ø) ⬆️
piptools/resolver.py 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903931f...d43445f. Read the comment docs.

atugushev
atugushev approved these changes Aug 14, 2019
View reviewed changes

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobtolar! LGTM 👍

@atugushev atugushev added this to the 4.1.0 milestone Aug 14, 2019
@atugushev
atugushev merged commit 4bfa887 into jazzband:master Aug 14, 2019
@atugushev atugushev added the enhancement Improvements to functionality label Aug 14, 2019
@atugushev

atugushev commented Aug 26, 2019

Copy link
Copy Markdown
Member

pip-tools v4.1.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atugushev atugushev atugushev approved these changes
+1 more reviewer
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvements to functionality

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

New argument '--no-emit-find-links' to pip-compile command

3 participants

@jacobtolar @atugushev @auvipy