Repository navigation
Add compatibility with pip==19.3 for refactored URL helpers - #910
Merged
atugushev merged 2 commits intoSep 26, 2019
Merged
Conversation
Function is_file_url() changed to Link.is_file property. Function is_dir_url() changed to Link.is_existing_dir() method. See pypa/pip#7036
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 98.57% 99.06% +0.48%
==========================================
Files 35 35
Lines 2247 2247
Branches 288 288
==========================================
+ Hits 2215 2226 +11
+ Misses 21 13 -8
+ Partials 11 8 -3
Continue to review full report at Codecov.
|
codingjoe
approved these changes
Sep 26, 2019
codingjoe
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
Is there a timeline yet, then the old util functions will be dropped?
Member
Author
|
Thanks for reviewing this! Much appreciated!
There is not. It needs to be discussed. Probably it's time to raise an issue. |
Member
Author
|
FYI, discussion started here #853. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compatibility with
pip==19.3for the following changes:Changelog-friendly one-liner: Add compatibility with
pip==19.3.Contributor checklist
Provided the tests for the changes.