Repository navigation
3.1.2 - #161
Merged
Merged
3.1.2#161
Conversation
…ates (#159) Bumps the github-actions group with 4 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/setup-java](https://github.com/actions/setup-java), [actions/cache](https://github.com/actions/cache) and [actions/setup-python](https://github.com/actions/setup-python). Updates `actions/checkout` from 6 to 7 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...v7) Updates `actions/setup-java` from 4 to 5 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) Updates `actions/cache` from 4 to 6 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v6) Updates `actions/setup-python` from 6 to 7 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v6...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/cache dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/setup-python dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker](https://github.com/docker/docker-py) from 7.1.0 to 7.2.0. - [Release notes](https://github.com/docker/docker-py/releases) - [Commits](docker/docker-py@7.1.0...7.2.0) --- updated-dependencies: - dependency-name: docker dependency-version: 7.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The provision check captured tee's exit code instead of minitrino's, so it always passed. On macOS this hid a real failure: Homebrew's docker formula lacks the Compose v2 plugin, so provision failed with 'unknown shorthand flag: f'. - Move the smoke test to smoke-test.yaml (workflow_call from release.yaml, plus workflow_dispatch and a pull_request trigger for changes to the workflow itself, testing the latest published version) - Use PIPESTATUS to capture the provision exit code - Install and register the docker-compose plugin on macOS, and verify Docker and Compose before provisioning - Validate the version input and restrict token permissions to read - Update workflow docs to reflect the actual four-stage release flow
With Compose fixed, provision on macOS got further and failed building the image: Homebrew's docker formula also lacks the Buildx plugin, so Compose fell back to the classic builder, which doesn't support additional build contexts. Install and register docker-buildx and verify it before provisioning.
When a PR doesn't change image files, CI pulls latest-trino/latest-starburst from GHCR instead of building. No workflow publishes those tags, so they were missing and every test job failed in setup with 'manifest unknown'. Change detection now builds test images whenever the fallback images can't be resolved.
The example MV selected 500 rows per UNION ALL branch while partitioning by orderdate, opening an ORC writer for nearly every row. Its refresh peaked at ~483 MB of the 614 MB per-node query limit locally and exceeded it in CI, failing the Starburst cache-service lib test. Selecting 50 rows per branch keeps the partitioned MV demo intact and drops peak refresh memory to ~57 MB.
A macOS smoke run hung in colima start for ~46 minutes until the hosted runner lost communication. Bound each start attempt to 8 minutes (observed normal starts: 4-6 minutes), retry once from a clean VM, and add step (20m) and job (35m) timeouts so a hung runner fails the release gate quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency Updates
click8.3.3 → 8.5.0 (from deps(deps): bump click from 8.3.3 to 8.5.0 #157; applied directly because Dependabot's rebase reset that PR's base tomaster)docker7.1.0 → 7.2.0 (deps(deps): bump docker from 7.1.0 to 7.2.0 #158)checkoutv7,setup-pythonv7,setup-javav5,cachev6 (ci(deps): bump the github-actions group across 1 directory with 4 updates #159)Library:
cache-serviceExample MV MemoryexampleMV (LIMIT 500perUNION ALLbranch, partitioned byorderdate) opened an ORC writer for nearly every row; its refresh peaked at ~483 MB of the 614 MB per-node limit locally and exceeded it in CI, deterministically failing the Starburstcache-servicelib testLIMIT 50per branch (still partitioned byorderdate); peak refresh memory ~57 MBCI/CD: Smoke Test False Passes
tee's exit code, so it always passed on both OSesdockerformula lacks the Compose v2 and Buildx pluginsPIPESTATUS[0]; install and registerdocker-composeanddocker-buildxon macOS; verifydocker info,docker compose version, anddocker buildx versionbefore provisioningCI/CD: Reusable Smoke Test Workflow
smoke-test.yaml, called fromrelease.yamlas the release gateworkflow_dispatch(any published version) and on PRs that modifysmoke-test.yaml(latest published version), so smoke test changes are validated before they gate a releaseX.Y.Z; token permissions restricted tocontents: readCI/CD: Build Test Images When Fallback Images Are Missing
latest-{trino,starburst}from GHCR, but no workflow publishes those tags, so every test job failed in setup withmanifest unknownDocs
Test plan
cache-servicewith 0 memory-limit errorscache-serviceexample MV refresh peak memory 483 MB → 57 MBFollow-ups (not in this PR)
latest-*test images frommasterso unchanged-image PRs skip builds (requirescleanup-test-images.yamlto not delete shared versions)CommandLineInterfacefromclick.MultiCommandtoclick.Groupbefore any Click 9.x bumpmacos-15-intel(last x64 macOS runner)