Repository navigation
perf: avoid unnecessary list allocation in CheckForIdlePlayback - #17411
Merged
crobibero merged 1 commit intoJul 25, 2026
Merged
Conversation
|
Shadowghost
approved these changes
Jul 23, 2026
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
Bond-009
approved these changes
Jul 23, 2026
cvium
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an unnecessary
.ToList()call inCheckForIdlePlayback.playingSessionsis already a materializedList<T>snapshot; the filteredidleenumerable is only iterated once withforeach, so materializing it into a second list serves no purpose and causes an avoidable heap allocation on every idle-check timer tick.