Skip to content

Fix extras naming and version assignment - #17456

Merged
crobibero merged 1 commit into
jellyfin:masterfrom
Shadowghost:fix-extras
Aug 2, 2026
Merged

crobibero merged 1 commit into
jellyfin:masterfrom
Shadowghost:fix-extras

Conversation

@Shadowghost

Copy link
Copy Markdown
Contributor

Changes

  • Extras are now named after what they are: "Trailer", "Behind The Scenes", numbered when a type repeats, instead of inheriting the owner's file name
  • TryGetExtraTypeForOwner hands back the rule it matched so an extra carrying a real title of its own ("Recording the audio-behindthescenes") keeps it, and a corrected name is persisted on the next refresh.
  • Remote metadata and image providers no longer run for extras, since an extra has no identity of its own
  • For an item with several versions, an extra named after a specific version file is assigned to that version, while folder-based extras and extras named after the item as a whole stay with the primary
    • Every version surfaces all of them, and the HasTrailer / HasSpecialFeature / HasThemeSong / HasThemeVideo filters match on any version.
    • Alternate versions and stacked parts are owned items but not extras, so they are no longer counted as such when deciding whether an item's extras changed.

Code assistance
Claude Opus 5 was used to trace the issue and write the tests.

Issues

@jellyfin-bot

Copy link
Copy Markdown
Contributor

Jellyfin API (v 12.0.0)


Result


No differences. Specifications are equivalent

@sonarqubecloud

Copy link
Copy Markdown

@Shadowghost
Shadowghost marked this pull request as ready for review July 27, 2026 21:12
@crobibero

Copy link
Copy Markdown
Member

How important is this fix? I think it is a bit late to be adding translations

@Shadowghost

Copy link
Copy Markdown
Contributor Author

Not that important, but since we are re-generating all Extras on the frist scan anyways, it would be a nice to have, otherwise we'll likely need to do another migration in 13.x

@theguymadmax theguymadmax moved this from Todo to In Progress in Jellyfin v12 Aug 1, 2026
@crobibero crobibero moved this from In Progress to Review in Jellyfin v12 Aug 1, 2026
@theguymadmax theguymadmax moved this from Review to Approved in Jellyfin v12 Aug 2, 2026
@crobibero
crobibero merged commit 2402209 into jellyfin:master Aug 2, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Jellyfin v12 Aug 2, 2026
@ScarletCarson

Copy link
Copy Markdown

This may have introduced a regression in bracketed version handling.

Up to 12 these worked:

├── Movie (2005) [imdbid-ttxx]
   ├── Movie (2005) [imdbid-ttxx] - [Original][1080p].mkv
   ├── Movie (2005) [imdbid-ttxx] - [Original][480p].mkv
   └── Movie (2005) [imdbid-ttxx] - [Original].mkv

After updating to 12.0-rc5 (to pick up the schedule-direct fix), these movies are still collpased into one title but the versions are missing and only one arbitrary selection is left. I've validated backwards to [1080p] and [480p] and they are picked up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants