Repository navigation
fix(images): disambiguate progress overlay cache keys - #17492
Merged
Merged
Conversation
GOvEy1nw
marked this pull request as ready for review
July 30, 2026 08:02
|
IDisposable
approved these changes
Aug 6, 2026
Shadowghost
approved these changes
Aug 6, 2026
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
crobibero
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix derivative image cache-key collisions between percent-played and unwatched-count overlays.
Problem
ImageProcessor.GetCacheFilePathserialized both overlay types using the samep=component. Two otherwise identical transformations with the same numericvalue could therefore produce the same derivative path even though they render
different overlays.
A focused regression test reproduces the collision on current master.
Implementation
pp=.uc=.Scope and non-goals
This change does not modify:
Validation
Focused baseline against old key behavior:
new cache-version snapshot.
After the fix:
10 skipped.
dotnet format --verify-no-changes --verbosity minimal: passed.git diff --check: passed.Tests cover:
No performance benchmark was run because this is a correctness fix. No
performance improvement is claimed.
Compatibility and cache migration
No public API or plugin interface changes.
The version bump causes one-time regeneration of transformed-image cache
entries after upgrade. Existing version-3 entries are no longer reused and
will eventually be removed by the existing daily cache cleanup.
Related work
PR #17420 also touches transformed-image caching but addresses atomic cache
publication and does not overlap this key-serialization fix.
No exact tracking issue was found during overlap searches.
Code assistance
An AI coding agent was used for repository navigation, implementation
assistance, test authoring, validation, and drafting. All changes and command
results were reviewed and verified before submission.