Repository navigation
Clear metadata provider cache when provider parts are registered - #17525
Merged
Merged
Conversation
AddParts replaces _metadataProviders but left _metadataProviderCache holding provider arrays from the previous registration. Invalidate the cache so repeated AddParts calls cannot serve stale providers, and give the previously uncalled ClearMetadataProviderCache its intended caller.
|
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
IDisposable
approved these changes
Aug 6, 2026
Contributor
|
Please fill out the PR template. |
Contributor
Author
Okay. |
crobibero
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AddPartsreplaces_metadataProvidersbut never invalidated_metadataProviderCache, so a second call would keep serving provider arrays from the previous registration.ClearMetadataProviderCache()was added for this but had no callers. This calls it at the end ofAddParts. Not a problem during normal startup, whereAddPartsruns once before anything populates the cache, but nothing enforces that single-call assumption.Code assistance
No.
Issues
N/A