Repository navigation
Speed up UpdateOrInsertItems for related information - #17554
Merged
Merged
Conversation
Makes the test O(log n)
Replace the O(n²) array .First scan with a dictionary lookup
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
|
Shadowghost
approved these changes
Aug 6, 2026
crobibero
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processing to find matching existing items and existing item values uses linear searches which are O(n²).
Changes
Replace the existing items ToArray() + First() scan with ToHashSet() + Contains() key lookup.
Replace the existing values .ToArray() + First() scan with ToDictionary() and dictionary lookup by key.
Code assistance
None
Issues
Speed up bulk saves of items.