Repository navigation
Safeguard against invalid provider ids - #17584
Conversation
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
|
THX that should mitigate a lot. I thought interface as well, but all plugins would need/should to adjust and provide a function or pattern. Would love to see a migration that cleans those faulty entries to avoid the exception with current data against pattern. Jellyfin has no data refresh task, so it will never be fixed over time without a manual refresh and a second run. Also, it will not be deleted on an update if wrong entry was just removed and not updated on e.g. TVDB. Additionally, still prefer to change the order of running things, so if provider fixes the ID, it doesn't need an additional run OR do not add 404 links - check HEAD. Sometimes even Didn't test it yet, because it conflicts with #17573 |
|
Was able to test it, and it works better as expected. Only one bit unrelated issue is still present: If something has no TMDB like a music group (TVDB has groups, TMDB not) and it will always add a TMDB ID with some random person not related to media or group. |
Co-Authored-By: Cody Robibero <cody@robibe.ro>
|
Changes
Validate IDs before running them and ignore invalid ones per-provider:
In the future we need to provide an interface so providers can give us their own validators.
Code assistance
Opus 5 was used to write the tests
Issues
Fixes #17581
More comprehensive alternative to #17583