Repository navigation
Fix series merging leaking across libraries and under-counting merged children - #17693
Merged
Merged
Conversation
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
crobibero
reviewed
Aug 22, 2026
crobibero
approved these changes
Aug 22, 2026
theguymadmax
approved these changes
Aug 22, 2026
|
Merged
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #17417
Series.PresentationUniqueKeyno longer carries the owning library, but the queries that resolve a merged series' children are not library-scoped:LibraryManager.AddUserToQuerydeliberately skipsTopParentIdswhenSeriesPresentationUniqueKeyorAncestorWithPresentationUniqueKeyis set. I missed this when I changed the behavior.Separately, played/total counts for a merged series are taken from the grouping survivor's own subtree, meaning they were wrong too.
Changes
Series.PresentationUniqueKey, now sorted withStringComparer.Ordinalso sibling folder-items cannot diverge on enumeration orderGetChildCountBatchfor merged foldersDescendantQueryHelper.GetAllDescendantIdsBatchso a group's descendants resolve in one traversalRecomputeSeriesPresentationKeyto a new date prefix and correct it in place to fix existing dataCode assistance
Claude Opus 5 for testing
Issues
Fixes #17692