Repository navigation
Fix transcode throttling not enabling on supported systems (caused by race condition) - #17906
Conversation
nyanmisaka
left a comment
There was a problem hiding this comment.
With -re, you can actually set :r=1 for nullsrc. Either way, it will take 5 seconds to complete.
Shadowghost
left a comment
There was a problem hiding this comment.
Can you please retarget and rebase onto the release branch
True, though reducing the framerate to 1 will somewhat reduce the snappiness of how fast ffmpeg is able to respond to the stdin inputs. Still I'd consider the current ~40 frames generated over the previous 250000 a fairly nice bonus already. (at least on my system)
It should take less than that, because I also added a |
122e4b5 to
ac08232
Compare
Should be done now! In case I should make any changes, is there a preference to use a new commit or amend+force the current one? Since the code change is fairly small (though with great impact for me!) |
The 25fps workload requirement from the past is no longer relevant. Therefore, setting
Yes, it usually ends with |
The previous duration was too short on faster systems for ffmpeg to print its runtime keybinds
ac08232 to
35c3d7d
Compare
|
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
Fix transcode throttling not enabling on supported systems (caused by race condition) Original-merge: b8b6e39 Merged-by: crobibero <cody@robibe.ro> Backported-by: Cody Robibero <cody@robibe.ro>
Changes
Made the
CheckSupportedRuntimeKey()function way more race condition resistent without increasing the runtime, as well as making it less resource intensive (by making the dummy job realtime).This fixes transcode throttling not getting enabled on supported systems that completed the old dummy job so fast that ffmpeg was not able to write its runtime key commands to the stdout.
Code assistance
Used ChatGPT to help understand what exactly all old ffmpeg arguments did.
NOT used for new code
Issues
Fixes #17905 (the issue also includes a root cause analysis)