Skip to content

Skip empty ZIP comments for ComicBookInfo - #17971

Merged
crobibero merged 2 commits into
jellyfin:release-12.zfrom
Shadowghost:fix-comicbookinfo
Sep 14, 2026
Merged

crobibero merged 2 commits into
jellyfin:release-12.zfrom
Shadowghost:fix-comicbookinfo

Conversation

@Shadowghost

Copy link
Copy Markdown
Contributor

Changes
Skip empty ZIP comments for ComicBookInfo

Code assistance
Claude Opus 5 for tests

Issues
Fixes #17969

@Shadowghost Shadowghost added the stable backport Backport into the next stable release label Sep 11, 2026
@jellyfin-bot

Copy link
Copy Markdown
Contributor

Jellyfin API (v 12.0.0)


Result


No differences. Specifications are equivalent

@oddstr13 oddstr13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, question on tests.

Comment thread tests/Jellyfin.Providers.Tests/Books/ComicBookInfoProviderTests.cs Outdated
@theguymadmax theguymadmax moved this from Todo to Review in Jellyfin v12 Sep 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@jellyfin-project-automation jellyfin-project-automation Bot added this to the v12.1 milestone Sep 12, 2026
@Shadowghost
Shadowghost requested review from a team and oddstr13 September 13, 2026 08:10
@jellyfin-project-automation jellyfin-project-automation Bot moved this from Review to Approved in Jellyfin v12 Sep 13, 2026
Comment thread MediaBrowser.Providers/Books/ComicBookInfo/ComicBookInfoProvider.cs
@crobibero
crobibero merged commit bdfdef3 into jellyfin:release-12.z Sep 14, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Jellyfin v12 Sep 14, 2026
joshuaboniface pushed a commit that referenced this pull request Sep 15, 2026
Skip empty ZIP comments for ComicBookInfo

Original-merge: bdfdef3

Merged-by: crobibero <cody@robibe.ro>

Backported-by: Cody Robibero <cody@robibe.ro>
@crobibero crobibero removed the stable backport Backport into the next stable release label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants