Repository navigation
Use Enumerable.LeftJoin for activity log user query - #17175
Merged
Merged
Conversation
IDisposable
approved these changes
Jun 25, 2026
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
Bond-009
approved these changes
Jun 28, 2026
Bond-009
force-pushed
the
fix/use-leftjoin-ef10
branch
from
June 30, 2026 15:37
723d385 to
f011529
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace the manual group join pattern with
Enumerable.LeftJoin, which was added in .NET 10 and is supported by EF Core 10. The previous approach usedinto ugjwithDefaultIfEmpty()to emulate a left join. The TODO comment at this site specifically requested this change once .NET 10 was available.Issues
N/A