Repository navigation
Check numeric rating value after splitting country code - #17273
Merged
Merged
Conversation
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
Shadowghost
approved these changes
Jul 9, 2026
IDisposable
approved these changes
Jul 9, 2026
Bond-009
reviewed
Jul 12, 2026
|
Bond-009
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were already converting plain numeric ratings straight to a score, e.g., a rating of 16 became a score of 16. But we only did that as a whole, not when a country code was present. So GR-16 would not match and would be treated as unrated.
Changes
18Code assistance
N/A
Issues
I've been seeing lots of log reports with parental rating being treated as unrated when there is a numerical value and a country code present.
[2026-07-08 02:51:46.466 +03:00] [WRN] [32] Emby.Server.Implementations.Localization.LocalizationManager: Rating '"GR-16"' not found in the '"GR"' rating system, treating as unrated