Repository navigation
Conversation
fma-rc
marked this pull request as ready for review
September 13, 2026 10:52
|
Contributor
Jellyfin API (v 12.0.0)ResultNo differences. Specifications are equivalent |
Shadowghost
approved these changes
Sep 13, 2026
IDisposable
approved these changes
Sep 14, 2026
joshuaboniface
pushed a commit
that referenced
this pull request
Sep 15, 2026
Fix device access revocation not logging out existing sessions Original-merge: 950c45c Merged-by: crobibero <cody@robibe.ro> Backported-by: Cody Robibero <cody@robibe.ro>
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removing a device from a user's allowed device list or switching off enable all devices only applied to new logins. Since commit d986a82 which converted
DeviceAccessHostfrom anIServerEntryPointto anIHostedService(which needs an explicitAddHostedService),DeviceAccessHostwas never run andOnUserUpdatedwas only raised forRenameUser. Fixed inUpdatePolicyAsyncin UserManager.cs by hoisting the user out of the lock scope and raisingOnUserUpdatedso it doesn't only apply to renames and then addingAddHostedService<DeviceAccessHost>()in Startup.cs. Added a logger to DeviceAccessHost.cs and a try/catch block aroundOnUserUpdatedbody. As a side effect of adding_eventManager.PublishAsync(eventArgs),UserUpdatedNotifiernow emits a user updated notification on policy change. I included 4 regression tests.Code assistance
Defect found by an LLM audit, then Opus 5 wrote the fix and regression tests and ran the test suite. Verified the changes myself.
Issues
None