Skip to content

Use MusicBrainz artist name first - #18192

Merged
crobibero merged 1 commit into
jellyfin:release-12.zfrom
juxuanu:patch-1
Sep 27, 2026
Merged

crobibero merged 1 commit into
jellyfin:release-12.zfrom
juxuanu:patch-1

Conversation

@juxuanu

@juxuanu juxuanu commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Use the MusicBrainz artist's own name, and fall back to the printed name when a credit has no artist. The lookups already request artist details (Include.Artists), so credit.Artist is filled in.

Commit b7b2700, part of #17424, made the MusicBrainz album metadata add the release's artist credits to an album's album-artists.

The bug: it uses the name as printed on the release, not the artist's MusicBrainz name.

The effect: the same artist appears under several names, one artist item per spelling, all with the same MusicBrainz artist id.

Example: release cef0552b-07e2-493d-99ee-6298734439c6 credits "Bach", "Beethoven" and "Haydn". Their MusicBrainz artists are Johann Sebastian Bach, Ludwig van Beethoven and Joseph Haydn. Any album that credits the full name then adds a second artist; for example, my library has "Beethoven" and "Ludwig van Beethoven", both with id 1f9df192-a621-4f54-8850-2c5373b7eac9.

What this doesn't change:

  • The search results in the "Identify" dialog still show printed names, at line 149 (Name = artist.Name). Not sure if you'd like me to include a change in there in the PR.

How to test: take an album whose MusicBrainz release prints a composer's short name. Refresh its metadata with "Replace all metadata", then check its album artists: you should see "Ludwig van Beethoven", not "Beethoven".
I tested this in a 12.1 container and it does fix it for me.

Code assistance

Claude helped identify what's going on. The one liner makes sense in my eyes, of course.

Issues

@Shadowghost

Copy link
Copy Markdown
Contributor

Please retarget and rebase onto the release branch

@jellyfin-bot

jellyfin-bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Jellyfin API (v 12.1.0)


Result


No differences. Specifications are equivalent

@juxuanu
juxuanu changed the base branch from master to release-12.z September 25, 2026 12:07
@juxuanu
juxuanu requested review from a team and joshuaboniface as code owners September 25, 2026 12:07
@juxuanu

juxuanu commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Please retarget and rebase onto the release branch

Done

@sonarqubecloud

Copy link
Copy Markdown

@Shadowghost
Shadowghost removed request for a team and joshuaboniface September 25, 2026 12:45
@Shadowghost Shadowghost added this to the v12.2 milestone Sep 25, 2026
@Shadowghost
Shadowghost requested a review from a team September 25, 2026 12:45
@jellyfin-project-automation jellyfin-project-automation Bot moved this from Review to Approved in Jellyfin v12 Sep 25, 2026
@crobibero
crobibero merged commit 311b634 into jellyfin:release-12.z Sep 27, 2026
16 checks passed
@juxuanu
juxuanu deleted the patch-1 branch September 27, 2026 22:12
@crobibero crobibero added the stable backport Backport into the next stable release label Oct 2, 2026
jellyfin-bot pushed a commit that referenced this pull request Oct 5, 2026
Use MusicBrainz artist name first

Original-merge: 311b634

Merged-by: crobibero <cody@robibe.ro>

Backported-by: Cody Robibero <cody@robibe.ro>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants