Repository navigation
Conversation
Member
|
Please retarget and rebase this to the current stable branch (release-12.z) |
maghuro
force-pushed
the
fix/codeql-fix-null-encoder-preset-tests
branch
from
September 29, 2026 15:11
fafaa9b to
d341176
Compare
Contributor
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
theguymadmax
approved these changes
Sep 29, 2026
crobibero
approved these changes
Sep 30, 2026
jellyfin-bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
Use XmlReader in encoder preset migration tests Original-merge: 4d3282b Merged-by: crobibero <cody@robibe.ro> Backported-by: Cody Robibero <cody@robibe.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use
XmlReaderwhen deserializingencoding.xmlinFixNullEncoderPresetTests. This resolves the pre-existing CA5369 analyzer errors that currently make the CodeQL C# autobuild fail onmaster, without changing runtime behavior.The failure was observed while validating #18056 and is also documented as pre-existing in #18236.
Code assistance
ChatGPT was used to inspect the failing CodeQL logs, identify the CA5369 root cause, compare existing Jellyfin XML deserialization patterns, and prepare this minimal test-only fix. The resulting diff was reviewed before opening the pull request.
Issues
None.