Skip to content

fix(riscv64): save trap registers before logging - #1

Open
deepai-org wants to merge 1 commit into
jietra:mainfrom
deepai-org:fix-trap-entry-save
Open

deepai-org wants to merge 1 commit into
jietra:mainfrom
deepai-org:fix-trap-entry-save

Conversation

@deepai-org

Copy link
Copy Markdown

Fix

Move the trap-entry log call after the general registers have been saved.

Currently la a0, trap_msg overwrites the interrupted a0, and call asm_puts overwrites ra and may clobber other caller-saved registers before they reach the trap frame. Saving that already-modified state cannot restore the interrupted context correctly.

Keep the same log message, frame layout and restore sequence; only move the logging after the saves.

Validation

Built this change alone against current main (3a2b8653) using Rust 1.97.1, clang and the RV64 target, then booted QEMU 8.2.2 virt with -bios none.

The existing deliberate illegal instruction reports mcause=2, mtval=0xffffffff, an exception PC matching the illegal instruction in the ELF, and mtvec matching trap_entry. Execution resumes through Exception handled successfully. and the final xWALT greeting. This checks the existing startup/trap-recovery path, not a full architectural register-preservation suite or RV64 hypervisor support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant