Repository navigation
fix(riscv64): save trap registers before logging - #1
Open
deepai-org wants to merge 1 commit into
Open
deepai-org wants to merge 1 commit into
deepai-org wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Move the trap-entry log call after the general registers have been saved.
Currently
la a0, trap_msgoverwrites the interrupteda0, andcall asm_putsoverwritesraand may clobber other caller-saved registers before they reach the trap frame. Saving that already-modified state cannot restore the interrupted context correctly.Keep the same log message, frame layout and restore sequence; only move the logging after the saves.
Validation
Built this change alone against current
main(3a2b8653) using Rust 1.97.1, clang and the RV64 target, then booted QEMU 8.2.2virtwith-bios none.The existing deliberate illegal instruction reports
mcause=2,mtval=0xffffffff, an exception PC matching the illegal instruction in the ELF, andmtvecmatchingtrap_entry. Execution resumes throughException handled successfully.and the final xWALT greeting. This checks the existing startup/trap-recovery path, not a full architectural register-preservation suite or RV64 hypervisor support.