🎉 Added incremental indexer command - #558
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
============================================
- Coverage 57.86% 56.58% -1.28%
- Complexity 1361 1390 +29
============================================
Files 339 340 +1
Lines 5273 5625 +352
============================================
+ Hits 3051 3183 +132
- Misses 2222 2442 +220 ☔ View full report in Codecov by Sentry. |
irfan-dahir
reviewed
Nov 7, 2024
pushrbx
commented
Nov 8, 2024
irfan-dahir
approved these changes
Nov 8, 2024
irfan-dahir
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently none of the indexing artisan commands can do incremental indexing. So far we relied on the season and schedule indexer (or full indexing in reverse order), but in case of self-hosted setups that's insufficient, the new entries from MAL never get imported. Not to mention manga entries.
This PR adds a new artisan command:
indexer:incremental. This command will compare the latest version of MAL ids from the mal_id_cache github repository and compares them with the downloaded ids from the previous run. If no ids found from the previous run, a full indexing session is started.Usage:
The first argument is an array, and it's required. You can also just run it with one media type to index:
You can also resume with
--resumeflag if you cancelled it. The command handles theSIGTERMsingal as well to gracefully stop.