Remove as_bool in Instruction trait#404
Merged
Merged
Conversation
CohenArthur
reviewed
Dec 3, 2021
CohenArthur
left a comment
Member
There was a problem hiding this comment.
This is suuuuuch a nice cleanup. Thanks a lot, this is fantastic!
Comment on lines
+138
to
+146
| match self.op { | ||
| Operator::Lt | ||
| | Operator::Gt | ||
| | Operator::LtEq | ||
| | Operator::GtEq | ||
| | Operator::Equals | ||
| | Operator::NotEquals => CheckedType::Resolved(TypeId::from("bool")), | ||
| _ => l_type, | ||
| } |
Member
There was a problem hiding this comment.
I think this might be missing checking that both the l_type and r_type are the same? Maybe I'm missing part of the function, I can't check it for now. If that is the case, could you add a test case for this as it is a typechecking error to operate on two types with different types and I should have added one already :)
Member
Author
There was a problem hiding this comment.
This done line 128. Don't know if this is tested though.
Member
There was a problem hiding this comment.
Ah, great thanks for checking!
Co-authored-by: CohenArthur <arthur.cohen@epita.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387