Skip to content

fix: prevent tenantId escalation via /user/update #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carfeii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent tenantId escalation via /user/update #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions jshERP-boot/src/main/java/com/jsh/erp/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,14 @@ public int insertUser(JSONObject obj, HttpServletRequest request)throws Exceptio
@Transactional(value = "transactionManager", rollbackFor = Exception.class)
public int updateUser(JSONObject obj, HttpServletRequest request) throws Exception{
User user = JSONObject.parseObject(obj.toJSONString(), User.class);
// tenantId must never be settable through this endpoint: updateByPrimaryKeySelective
// writes every non-null field from the client-supplied JSON, and the tenant SQL
// parser only scopes which row the UPDATE's WHERE clause can reach (by the caller's
// own tenant), not what the SET clause is allowed to write. Without this, a caller
// could set their own (or any row within their tenant's) tenantId to 0, which the
// tenant filter treats as unrestricted super-admin access on every later request
// made with that user's token.
user.setTenantId(null);
int result=0;
try{
//判断是否登录过
Expand Down