Skip to content

feat(recording): make live-streaming dialog service-agnostic (#8955) - #17870

Open
muskan-creates352 wants to merge 1 commit into
jitsi:masterfrom
muskan-creates352:feat/live-stream-dialog-ungoogle
Open

muskan-creates352 wants to merge 1 commit into
jitsi:masterfrom
muskan-creates352:feat/live-stream-dialog-ungoogle

Conversation

@muskan-creates352

Copy link
Copy Markdown
Contributor

Fixes #8955

Description

Jitsi Meet (via Jibri) supports live streaming to any generic RTMP destination (e.g. Owncast, Twitch, custom RTMP servers). However, the client dialog was tightly coupled to YouTube:

  • Input placeholder explicitly asked for "YouTube live stream key".
  • Key validation rejected standard RTMP/RTMPS URLs with "Live stream key may be incorrect".
  • YouTube Studio Go Live warnings and YouTube/Google terms and policies were unconditionally rendered even when Google API was not configured.

Changes

  • Added STREAM_KEY_OR_URL_REGEXP supporting RTMP/RTMPS URLs, YouTube 4-group keys, and generic stream keys.
  • Made YouTube Studio warning conditional on _googleApiApplicationClientID.
  • Service-agnostic placeholder and terms labels for Web and Native dialogs.

@jitsi-jenkins

Copy link
Copy Markdown

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"ungoogle" live-streaming dialog

2 participants