Skip to content

Add support for CR and CRLF newlines - #13

Merged
parkr merged 1 commit into
jm:masterfrom
koraktor:parslet-newlines
Sep 1, 2014
Merged

Add support for CR and CRLF newlines#13
parkr merged 1 commit into
jm:masterfrom
koraktor:parslet-newlines

Conversation

@koraktor

Copy link
Copy Markdown
Contributor

This allows to parse TOML files saved with CR (Mac) or CRLF (DOS) newlines.

@88Alex

88Alex commented Jul 5, 2013

Copy link
Copy Markdown

'\n' evaluates to CRLF on Windows and CR on Unix systems anyway, so there's no need.

@koraktor

koraktor commented Jul 5, 2013

Copy link
Copy Markdown
Contributor Author

There's a need because you can't parse files with CRLF on UNIX systems.

@lessless

Copy link
Copy Markdown

@koraktor @dirk
I hope this can fix #24

@parkr

parkr commented Feb 17, 2014

Copy link
Copy Markdown
Collaborator

This can't be merged at the moment – would you mind redoing your current PR off the master branch, whether that means spiking out a new PR or rebasing the current stuff? Thanks!

@koraktor

Copy link
Copy Markdown
Contributor Author

Done. 😏

@parkr

parkr commented Aug 31, 2014

Copy link
Copy Markdown
Collaborator

Hey, what are your thoughts on this? Still interested in seeing this being merged?

@koraktor

koraktor commented Sep 1, 2014

Copy link
Copy Markdown
Contributor Author

I no longer use TOML in any of my projects, so I'm not personally interested in this issue.

But isn't that problem simple and clear enough to just merge that patch?

@parkr

parkr commented Sep 1, 2014

Copy link
Copy Markdown
Collaborator

Yep, thanks!

parkr added a commit that referenced this pull request Sep 1, 2014
Add support for CR and CRLF newlines
@parkr
parkr merged commit d39648b into jm:master Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants