release: v1.17.0 - #10795
Open
skyfallsin wants to merge 10 commits into
Open
release: v1.17.0#10795skyfallsin wants to merge 10 commits into
skyfallsin wants to merge 10 commits into
Conversation
POST /tabs/:tabId/fetch-current-resource re-fetched page.url() through the Node-side APIRequestContext. Hosts that gate PDFs behind a JS redirect or bot challenge (observed: PMC, invisible reCAPTCHA Enterprise then redirect to the .pdf) accept the browser but answer the Node refetch with HTML/403, so the route returned 415 while the tab was rendering the PDF. Track the last main-frame navigation response per tab and, when its URL matches the current page and its content-type is application/pdf, return that body directly. Fall back to the existing refetch otherwise. Covered by tests/unit/inline-pdf-response.test.js; verified live against PMC9250870 (2.5 MB PDF, previously 415). Claude-Session: https://claude.ai/code/session_013ANmcszistnKMhaST9xcUX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.17.0
Includes #10784: persist a PDF that the current browser tab already received, avoiding a second request that challenge-protected hosts can reject.
Also rejects an inline PDF from its declared Content-Length before reading its body, preserving the existing 50 MB resource limit.
Validation:
NODE_OPTIONS=--experimental-vm-modules npx jest --runInBand tests/unit/inline-pdf-response.test.jsgit diff --check