Added stackdriver severity compatibility, fixed panic logging#9
Merged
balboah merged 1 commit intojoonix:masterfrom Jan 30, 2019
Merged
Conversation
adamjyounger
approved these changes
Jan 22, 2019
balboah
approved these changes
Jan 30, 2019
Member
balboah
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation logrus log levels are used as raw string values. This will will not output logrus panics as a correct FluentD log level value. In addition warning levels are not outputting the correct FluentD warning level 'warn'.
This PR also addresses the fact that google changed the severity level names and casing requirements in their stack driver implemetation. To transparently facilitate this, I added the UseStackdriverSeverity package level function.