Merged
Conversation
Refactor save file path retrieval logic Refactor file path retrieval to check environment variable, config file, and default path for saving notes and backups. Refactor ThothConfig structure and default implementation Remove default implementation for ThothConfig and add notes_path field. Changed to notes_dir Remove unnecessary changes Ran tests and clippy
Added section on customizing notes location with environment variable and config file examples. Align README More README fixes
Removed unnecessary whitespace in load and save methods.
Contributor
Author
|
@jooaf So it seems that the build check failed because of a problem with the CI/CD pipeline and not the code. Let me know if you take a look at the code and see anything weird. |
Owner
|
Hi @robertoash, so sorry I've been on vacation and I'm still traveling but let me take a look at this |
Owner
|
thanks for your contribution :) ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added custom location for thoth notes. The app will now look for custom locations with this priority:
Backups and clipboard md files are placed in the same location.