Regression plan includes entries from releases the matrix skips by joslat · Pull Request #219 · joslat/maf-doctor

joslat · 2026-10-01T16:21:34Z

Bug: maf_generate_regression_plan's steps follow the compatibility matrix, which has no rows for 1.6.0, 1.6.2, 1.7.0, 1.8.0 or 1.9.0. Each step listed only entries introduced exactly at that step's version. So a 1.7.0 → 1.10.0 plan, which is one step, dropped the 1.8.0/1.9.0 entries backfilled in #217: the session-isolation default, the declarative code-gen removal, and the Harness changes.

Fix: a step now lists the entries introduced in (source, step], still evaluated against the source codebase.

Tests: new Plan_StepOverSkippedReleases_IncludesTheirEntries; full suite passes (1319 tests).

Also in this PR: the notes fix for the two 1.1.0 entries that the semantic review warned about on #218.

🤖 Generated with Claude Code

… notes Semantic review on #218 warned that the 'both constructors changed' claims in MAF11-SKILL-INLINE-001 and MAF11-SKILL-PROVIDER-001 were not grounded in the notes; the diff shows both overloads changing, now quoted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The plan's steps follow the compatibility matrix, which has no rows for 1.6.0, 1.6.2, 1.7.0, 1.8.0 or 1.9.0. Each step listed only entries with VersionIntroduced == step, so a 1.7.0 -> 1.10.0 plan (one step) dropped the 1.8.0/1.9.0 entries backfilled in #217 (session isolation default, declarative code-gen removal, Harness). A step now lists entries introduced in (source, step], still evaluated against the source codebase. New test: Plan_StepOverSkippedReleases_IncludesTheirEntries. 1318+1 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-01T16:22:27Z

🟢 MAF health grade: A

no errors, no warnings, no silent-starvation risks, all agent call sites bounded

Repo: /home/runner/work/maf-doctor/maf-doctor

🩺 This is a read-only diagnosis — doctor never edits your files. Nothing needs fixing.

Metric	Count
Anti-pattern errors	0
Anti-pattern warnings	0
Anti-pattern info notes	0
Silent-starvation risks (fan-out handlers)	0
`[MessageHandler]` methods inspected	0
Prompt-lint errors (injection / etc)	0
Prompt-lint warnings (refusals / bloat)	0
Agent call sites without `MaxOutputTokens` cap	0
`RunAsync` / `RunStreamingAsync` sites inspected	0

✅ No fixes recommended — repo is clean against all configured rules.

Want more

Every finding (full triage): --all (CLI) or full: true (MafDoctor MCP).
Machine-readable JSON (CI / dashboards): --json (CLI) or format: "json" (MafDoctor MCP).
Ordered, checkboxed remediation plan (drop into a GitHub issue): --plan (CLI) or format: "plan" (MafDoctor MCP).
Deep-dive ONE finding (offending code in context + why + fix) — MCP clients only (no CLI flag): MafExplainFinding(repoPath, file, line) or the maf-explain-finding prompt.
Deeper per-area analysis in your MCP client (Copilot / Claude / Cursor): MafScanAntiPatterns, MafValidateFanOut, MafSimulateWorkflow, MafRunCs0618Hunt — the anti-pattern + fan-out scanners also emit SARIF (format: "sarif").

Audited commit: ef109638dd350a46b9ddc67c2fc1c5d9e9e447d7

github-actions · 2026-10-01T16:22:34Z

✅ AI-fill verification passed (registry + cross-file + scaffold-preservation checks).

Audited commit: ef109638dd350a46b9ddc67c2fc1c5d9e9e447d7

github-actions · 2026-10-01T16:22:48Z

Reviewed head: ef109638dd350a46b9ddc67c2fc1c5d9e9e447d7

✅ AI Semantic Review — verdict: PASS

Reviewed 2 changed registry entries: PASS=2, WARN=0, FAIL=0.

All filled entries are semantically consistent with the dotnet-inspect diff captured in their notes: field.

This is rung-2 of the AI trust ladder (comment-only). The human still merges. To turn this into a hard gate, flip COMMENT_ONLY_MODE in .github/scripts/ai_review_post_comment.py.

✅ `MAF11-SKILL-INLINE-001` — PASS

No issues found.

✅ `MAF11-SKILL-PROVIDER-001` — PASS

No issues found.

github-actions · 2026-10-01T16:23:57Z

🔍 Cisco mcp-scanner result

=== MCP Scanner Results Summary ===

Scan Target: stdio:dotnet run --project src/maf-autopilot --framework net10.0 --no-build
Total tools scanned: 28
No results match the specified filters.

_{Scan covers prompt-injection, tool-poisoning, credential-harvesting,

code-execution, parameter-injection, cross-origin-escalation, and rug-pull

patterns. See docs/security.md for the canonical interpretation. This

check is a required gate — see the "Run mcp-scanner" step above for the

exact pass/fail evaluation.}

Audited commit: ef109638dd350a46b9ddc67c2fc1c5d9e9e447d7

Copilot

Copilot review overview

🟡 Changes recommended

The new test must follow the repository’s mandatory naming and AAA structure.

Review effort: Balanced
Findings: 1

Open (1)

Test lacks required naming and Arrange/Act/Assert structure · New

What changed in this PR

Updates regression-plan generation so skipped compatibility-matrix releases still contribute registry entries.

Changes:

Selects entries from the full (source, target] version range.
Adds regression coverage for skipped releases.
Clarifies registry evidence and records the fix.

File	Description
`RegressionPlanTool.cs`	Adds range-based registry selection.
`RegressionPlanToolTests.cs`	Tests skipped-release handling.
`CHANGELOG.md`	Documents the regression fix.
`registry.yaml`	Expands 1.1.0 overload evidence.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    public void Plan_StepOverSkippedReleases_IncludesTheirEntries()
+    {
+        // The compatibility matrix has no 1.8.0/1.9.0 rows, so 1.7.0 -> 1.10.0 is
+        // one step. Entries introduced in the skipped releases must still appear.
+        var result = _tool.MafGenerateRegressionPlan("1.7.0", "1.10.0");
+        Assert.Contains("`MAF180-HOSTING-STORE-001`", result);
+        Assert.Contains("`MAF190-HARNESS-AGENT-001`", result);
+        Assert.Contains("`MAF110-HARNESS-AGENT-001`", result);
+        // Already-passed releases (1.6.x and earlier) must not appear.
+        Assert.DoesNotContain("`MAF162-FOUNDRY-EXTENSIONS-001`", result);
+    }


joslat and others added 2 commits October 1, 2026 18:17

Copilot AI balanced review requested due to automatic review settings October 1, 2026 16:21

Copilot started reviewing on behalf of joslat October 1, 2026 16:22 View session

joslat merged commit 389f0b3 into main Oct 1, 2026
20 checks passed

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Navigation Menu

Repository navigation

Regression plan includes entries from releases the matrix skips - #219

Regression plan includes entries from releases the matrix skips#219
joslat merged 2 commits into
mainfrom
selfheal/zero-touch

joslat commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

joslat commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

🟢 MAF health grade: A

Want more

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

✅ AI Semantic Review — verdict: PASS

✅ MAF11-SKILL-INLINE-001 — PASS

✅ MAF11-SKILL-PROVIDER-001 — PASS

Uh oh!

github-actions Bot commented Oct 1, 2026

🔍 Cisco mcp-scanner result

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

✅ `MAF11-SKILL-INLINE-001` — PASS

✅ `MAF11-SKILL-PROVIDER-001` — PASS