Skip to content

Rework how all output and messaging works in jrnl - #1475

Merged
wren merged 67 commits into
jrnl-org:developfrom
wren:print-output-1024
Jun 11, 2022
Merged

Rework how all output and messaging works in jrnl#1475
wren merged 67 commits into
jrnl-org:developfrom
wren:print-output-1024

Conversation

@wren

@wren wren commented May 7, 2022 •
edited by micahellison
Loading

Copy link
Copy Markdown
Member

The main idea behind all of this is to get all user-facing output centralized into one file. This will make it much easier to translate jrnl into different languages later (since we can just swap out the file for an equivalent one in a different language).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren added 30 commits May 7, 2022 13:10
@wren
fix missed statement from last PR
e130f26
@wren
replace print statement for adding an entry to a journal
f1bd015
@wren
WIP
4b9fe0c
@wren
clean up linting and format
253b807
@wren
change print statement over to new print_msg function
f142c91
@wren
make print_msg always print to stderr
0fc8bcf
@wren
change print statement over to new print_msg function
4237376
@wren
update importer to use new message function
c16aa42
@wren
update yaml format to use new message function
7ded211
@wren
code cleanup
af220be
@wren
update yaml format to use new message function
7eb385d
@wren
update yaml format to use new exception handling
6945d6a
@wren
update Journal class to use new message function
7690594
@wren
update install module to use new message function
2df7419
@wren
update config module to use new message function
8088083
@wren
update upgrade module to properly use new message and exception handling
9c030ac
@wren
fix typo
cf5b177
@wren
update upgrade module to use new message handling
cd464ee
@wren
update welcome message to use new handling
f1119e1
@wren
update upgrade module to use new message handling
93650f9
@wren
update upgrade module journal summaries to use new message handling
1b6c3ed
@wren
take out old code
03c0ae3
@wren
update upgrade module to use new message handling
3ccf695
@wren
update upgrade module to use new message handling
48d36ec
@wren
update more modules to use new message handling
9eb3e16
@wren
take out old comment
8da4a99
@wren
update deprecated_cmd to use new message handling
2871213
@wren
update text_exporter with new message handling, get rid of old color …
eeca1e2 
…constants
@wren
get rid of hardcoded text
fd93092
@wren
whitespace changes
6f5a082
wren added 22 commits May 17, 2022 12:34
@wren
clean up create_password function
1a6afd9
@wren
clean up misc linting
fabcd53
@wren
WIP
32ab358
@wren
rename screen_input to hide_input to be more clear
ebfc7bd
@wren
update encrypted journal prompt to use new messaging functionality
71eb746
@wren
fix typo in message key
bdbd3ca
@wren
move rich console into function so we can mock properly
4636f1a
@wren
update password mock to use rich console instead of getpass
1461f03
@wren
add more helpful output to then step
a15807a
@wren
fix test by updating expected output
bf8e779
@wren
update message to use new functionality
d2f2967
@wren
rework mocks in test suite for new messaging functionality
34df64c
@wren
fix linting issue
c325ba3
@wren
fix more tests
5cb46f5
@wren
fix more tests
57f53e9
@wren
fix more tests
920bc80
@wren
fix more tests
178c913
@wren
merge in develop
15b86ca
@wren
fix merge bug
517c522
@wren
update prompt_action_entries to use new messaging functionality
ac05bc6
@wren
Add new input_method "type"
6d18e75 
This does the same thing as input_method "pipe" but is more clear what
it's doing (typing text into the builtin composer)
@wren
get rid of old commented code
f1c5cba
@wren
wren marked this pull request as ready for review June 11, 2022 19:24
@wren wren changed the title [WIP] Rework how all output and messaging works in jrnl Rework how all output and messaging works in jrnl Jun 11, 2022
@micahellison micahellison linked an issue Jun 11, 2022 that may be closed by this pull request
Modularize console output messages #1024
Closed
micahellison
micahellison approved these changes Jun 11, 2022
View reviewed changes

@micahellison micahellison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@wren
wren merged commit f53110c into jrnl-org:develop Jun 11, 2022
@wren
wren deleted the print-output-1024 branch June 11, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahellison micahellison micahellison approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modularize console output messages

2 participants

@wren @micahellison