Repository navigation
fix: guarantee editor tempfile cleanup and add debug logging - #2106
Merged
Merged
Conversation
alichtman
commented
Jul 20, 2026
Contributor
- fix: guarantee editor tempfile cleanup on failure
- feat: add debug logging to editor.py
- feat: log the editor command when opening it in append mode
get_text_from_editor left the tempfile on disk if subprocess.call raised (e.g. misconfigured editor), since os.remove only ran after a successful read. Wrap the write/invoke/read in try/finally so the tempfile is always removed.
get_text_from_editor had no logging despite spawning a subprocess and doing disk I/O. Add debug logs around tempfile creation/cleanup and editor invocation, an error log when the editor is misconfigured, and a debug log in read_template_file's FileNotFoundError handler for parity with the existing debug log in get_template_path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.