Repository navigation
Remove unused 'autoCreate' parameter from getIssuer() function - #18
Merged
Merged
Conversation
jsha
requested changes
Jan 7, 2019
jsha
left a comment
Owner
There was a problem hiding this comment.
Thanks for the patch! I would rather remove the unused parameter instead. Would you be willing to make that change?
Contributor
Author
|
Yep, will do
Am 7. Januar 2019 17:52:54 MEZ schrieb Jacob Hoffman-Andrews <notifications@github.com>:
…jsha requested changes on this pull request.
Thanks for the patch! I would rather remove the unused parameter
instead. Would you be willing to make that change?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#18 (review)
|
The parameter was not being used (i.e. even if autoCreate == false the CA would be created).
Contributor
Author
|
Done |
jsha
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter was not being used (i.e. even if autoCreate == false the
CA would be created).