removing redundant block.Type check#7
Merged
jsha merged 2 commits intojsha:masterfrom Jul 13, 2018
actualben:master
Merged
Conversation
Creating 2016-dated, jsha-owned MIT license (from github templates)
Collaborator
Author
|
I added in the license file to close #6 but this could probably come in a different PR if that's easier |
|
Hi there @actualben , the license you added looks like the same thing I would have done had you not beaten me to it; LGTM! In this PR description you could put a line that says |
Closed
jsha
approved these changes
Jul 13, 2018
Owner
|
Thanks @actualben ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6 (adding this desc. post-merge, so it may not work, sorry about the delay)