Skip to content

Feature/add on exception join point - #4

Merged
k1r0s merged 10 commits into
k1r0s:masterfrom
alexjoverm:feature/add-onException-joinPoint
Jun 1, 2017
Merged

Feature/add on exception join point#4
k1r0s merged 10 commits into
k1r0s:masterfrom
alexjoverm:feature/add-onException-joinPoint

Conversation

@alexjoverm

Copy link
Copy Markdown
Contributor

No description provided.

    The joinPoint will trigger after all "beforeMethod" advices, preventing the original method to
    trigger because is triggered by itself. For now, this takes into account that only one @onException
    will be used per method

    Closes k1r0s#2
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.7%) to 95.506% when pulling c5ffe30 on alexjoverm:feature/add-onException-joinPoint into 7f6865c on k1r0s:master.

@k1r0s

k1r0s commented Jun 1, 2017

Copy link
Copy Markdown
Owner

Hi, thanks for the PR, seems pretty good.

@k1r0s
k1r0s merged commit 36c55a9 into k1r0s:master Jun 1, 2017
@k1r0s

k1r0s commented Jun 1, 2017

Copy link
Copy Markdown
Owner

I broke lint check :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants