Skip to content

Update golangci-lint to v1.21.0 - #376

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
ferhatelmas:bump-golangci
Nov 12, 2019
Merged

Update golangci-lint to v1.21.0#376
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
ferhatelmas:bump-golangci

Conversation

@ferhatelmas

@ferhatelmas ferhatelmas commented Nov 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Incremental analysis is added.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2019
@ferhatelmas

ferhatelmas commented Nov 11, 2019

Copy link
Copy Markdown
Contributor Author

There are some new linters; like whitespace (enforces using more whitespace).

Should we evaluate them if we want to enable or not? To me, we have something stable and new ones have overlapping functionality with existing ones.

@corneliusweig

corneliusweig commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

To me, we have something stable and new ones have overlapping functionality with existing ones.

If I understand this comment correctly, you are saying that you don't see the need to enable more linters. Is that correct?

@ferhatelmas

ferhatelmas commented Nov 11, 2019

Copy link
Copy Markdown
Contributor Author

Yes.

In general, we can keep an eye for newcomers but for now, new ones are related to style and not needed, I think.

@corneliusweig

corneliusweig commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

I see. Thanks for keeping this up-to-date!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@k8s-ci-robot

k8s-ci-robot commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 6eb962a into kubernetes-sigs:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb
@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@corneliusweig corneliusweig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferhatelmas @corneliusweig @k8s-ci-robot