Repository navigation
add utility method to list installed plugins by index - #549
Merged
k8s-ci-robot merged 1 commit intoMar 13, 2020
Merged
Conversation
Extract core of ListInstalledPlugins to filter installed plugin "by index" (this will be used for `krew index delete`, to check if an index is being deleted that has plugins installed). Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
commented
Mar 12, 2020
| } | ||
| } | ||
|
|
||
| func TestInstalledPluginsFromIndex(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
@chriskim06 I'm hoping this is a good test example for reproducing elsewhere.
corneliusweig
approved these changes
Mar 12, 2020
corneliusweig
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
/approve
/hold
Due to pending comment.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract core of ListInstalledPlugins to filter installed plugin "by index"
(this will be used for
krew index delete, to check if an index is beingdeleted that has plugins installed).
/assign @corneliusweig