Skip to content

chose: update go module dependencies - #829

Merged
k8s-ci-robot merged 5 commits into
masterfrom
ahmet/update-deps
Jul 13, 2023
Merged

k8s-ci-robot merged 5 commits into
masterfrom
ahmet/update-deps

Conversation

@ahmetb

@ahmetb ahmetb commented Jul 13, 2023

Copy link
Copy Markdown
Member

Periodic update to pick up security fixes etc and tag a release.

@ahmetb
ahmetb requested a review from chriskim06 July 13, 2023 20:36
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested a review from soltysh July 13, 2023 20:36
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2023
ahmetb added 3 commits July 13, 2023 13:45
seeing error

```
Installing golangci-lint
golangci/golangci-lint info checking GitHub for tag 'v1.44.0'
golangci/golangci-lint info found version: 1.44.0 for v1.44.0/linux/amd64
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x4b4
```
@chriskim06

Copy link
Copy Markdown
Member

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
k8s-ci-robot merged commit ac28333 into master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants