(preexisting / non-blocking)

rereading this, the function name / godoc on this function and the function above are confusing... it sounds like they will return observedGeneration, but they are returning generation

I'm having a hard time coming up with an alternative name that isn't ridiculously long, but I think the current names will lead to callers accidentally using these incorrectly

as a follow-up, consider if we can name these better to make it clearer the thing being returned is the passed-in generation or 0

CalculatePodStatusObservedGeneration and CalculatePodConditionObservedGeneration maybe?

I’ll submit a follow up

This is going to get a little messy, but I don't think we can use pod.Status here. This condition gets passed to evictPod which in turn calls killPodFunc with a status-updating method. This should use the status that's passed in to that function.

Here's what I think you should do:

1. Unconditionally set ObservedGeneration: pod.Generation here
2. Before UpdatePodCondition is called (line 622), update the observed generation with GetPodObservedGenerationIfEnabledOnCondition:

		if condition != nil {
+			condition.ObservedGeneration = podutil.GetPodObservedGenerationIfEnabledOnCondition(status, condition.ObservedGeneration, condition.Type)
			podutil.UpdatePodCondition(status, condition)
		}

Alternatively, you could consider making this part of UpdatePodCondition, but that's a bigger change.

thanks, your comment made me think way harder about what is going on here (what I should have been doing to begin with)

fixed!