Conversation
The ovmf package on Ubuntu 24.04 only ships OVMF_CODE_4M.fd, but qemuFirmwarePath always returns OVMF_CODE.fd. The provider status check stats that path first, so minikube start fails with PROVIDER_QEMU2_NOT_FOUND before qemu ever runs. Related to kubernetes#23628.
|
Hi @marwan562. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marwan562 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
On Ubuntu 24.04 the ovmf package only ships OVMF_CODE_4M.fd, but the qemu2 health check stats OVMF_CODE.fd first and fails the provider with PROVIDER_QEMU2_NOT_FOUND. I have taught qemuFirmwarePath to use whichever file exists, preferring the old name. This lets #23688 drop its CI symlink once it lands, but it does not cover the macOS runner story. Tests: go test ./pkg/minikube/registry/drvs/qemu2/... passes, including a new TestFirstExistingFirmware. Related to #23628.