Skip to content

test: expand smoke test matrix with qemu on macOS - #23764

Open
ayyYoSam wants to merge 1 commit into
kubernetes:masterfrom
ayyYoSam:test/23743-expand-smoke-matrix
Open

test: expand smoke test matrix with qemu on macOS#23764
ayyYoSam wants to merge 1 commit into
kubernetes:masterfrom
ayyYoSam:test/23743-expand-smoke-matrix

Conversation

@ayyYoSam

@ayyYoSam ayyYoSam commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Expands the smoke test matrix by adding a macOS x86_64 variant using the QEMU driver with containerd.

The new variant also installs the required qemu and socket_vmnet dependencies before running the existing smoke test flow.

Why this approach

I kept the initial change conservative to avoid introducing combinations that may require additional workflow changes or have platform-specific limitations.

There may be additional variants worth adding, including other operating systems, drivers, or architectures. If maintainers would like the matrix to cover additional combinations, I ask them to let me know and I'll add them myself.

Fixes #23743

@kubernetes-prow

kubernetes-prow Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayyYoSam
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2026
@kubernetes-prow

kubernetes-prow Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Hi @ayyYoSam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot

minikube-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@nirs

nirs commented Sep 21, 2026

Copy link
Copy Markdown
Member

@ayyYoSam Check git history. We removed qemu from macOS smoke tests recently since brew does not support intel runners now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prezha prezha Awaiting requested review from prezha
@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve test coverage in smoke test

3 participants

@ayyYoSam @minikube-bot @nirs