Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Refactor semi mask - #4940

Merged
andyfengHKU merged 2 commits into
masterfrom
refactor-semi-mask
Feb 25, 2025
Merged

Refactor semi mask#4940
andyfengHKU merged 2 commits into
masterfrom
refactor-semi-mask

Conversation

@andyfengHKU

@andyfengHKU andyfengHKU commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove tableID field from semi mask. Also make operator generate table_id_map_t<SemiMask> instead of vector<SemiMask> which is easier to read.

@github-actions

github-actions Bot commented Feb 20, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: bf8c8b88cbdeb1a10e58e53a07a156ea72932d40
Branch commit hash: 0a24c6299972b281a587e141f24801d610cb7d83

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 721.71 722.70 -0.99 (-0.14%)
aggregation q28 6369.47 6396.89 -27.42 (-0.43%)
filter q14 128.24 130.34 -2.10 (-1.61%)
filter q15 122.61 125.08 -2.47 (-1.98%)
filter q16 318.56 306.73 11.83 (3.86%)
filter q17 447.48 448.03 -0.55 (-0.12%)
filter q18 1884.33 1934.88 -50.55 (-2.61%)
filter zonemap-node 89.06 94.15 -5.09 (-5.40%)
filter zonemap-node-lhs-cast 89.29 90.39 -1.10 (-1.21%)
filter zonemap-node-null 88.77 89.94 -1.17 (-1.30%)
filter zonemap-rel 5612.25 5587.69 24.57 (0.44%)
fixed_size_expr_evaluator q07 578.93 570.73 8.20 (1.44%)
fixed_size_expr_evaluator q08 810.28 801.53 8.74 (1.09%)
fixed_size_expr_evaluator q09 808.98 800.49 8.49 (1.06%)
fixed_size_expr_evaluator q10 243.16 236.62 6.54 (2.76%)
fixed_size_expr_evaluator q11 236.27 230.25 6.01 (2.61%)
fixed_size_expr_evaluator q12 233.99 226.52 7.47 (3.30%)
fixed_size_expr_evaluator q13 1453.69 1458.46 -4.77 (-0.33%)
fixed_size_seq_scan q23 115.71 108.92 6.80 (6.24%)
join q29 770.59 768.96 1.62 (0.21%)
join q30 10038.95 11630.24 -1591.29 (-13.68%)
join q31 9.46 8.94 0.51 (5.74%)
join SelectiveTwoHopJoin 51.31 57.24 -5.93 (-10.36%)
ldbc_snb_ic q35 2781.83 2621.22 160.61 (6.13%)
ldbc_snb_ic q36 489.61 484.63 4.98 (1.03%)
ldbc_snb_is q32 5.10 5.68 -0.59 (-10.35%)
ldbc_snb_is q33 15.08 15.43 -0.35 (-2.25%)
ldbc_snb_is q34 1.25 1.20 0.05 (4.57%)
multi-rel multi-rel-large-scan 1330.26 1499.32 -169.07 (-11.28%)
multi-rel multi-rel-lookup 28.24 44.94 -16.70 (-37.16%)
multi-rel multi-rel-small-scan 89.88 88.16 1.72 (1.96%)
order_by q25 130.22 134.53 -4.31 (-3.20%)
order_by q26 456.73 461.64 -4.91 (-1.06%)
order_by q27 1406.74 1407.49 -0.74 (-0.05%)
recursive_join recursive-join-bidirection 309.85 305.79 4.07 (1.33%)
recursive_join recursive-join-dense 7075.57 7092.58 -17.02 (-0.24%)
recursive_join recursive-join-path 23607.91 23969.41 -361.51 (-1.51%)
recursive_join recursive-join-sparse 1049.21 1047.42 1.79 (0.17%)
recursive_join recursive-join-trail 7036.45 7036.01 0.44 (0.01%)
scan_after_filter q01 172.60 172.68 -0.08 (-0.05%)
scan_after_filter q02 157.01 157.25 -0.24 (-0.15%)
shortest_path_ldbc100 q37 90.18 82.22 7.96 (9.68%)
shortest_path_ldbc100 q38 398.55 325.19 73.36 (22.56%)
shortest_path_ldbc100 q39 65.47 60.50 4.96 (8.20%)
shortest_path_ldbc100 q40 421.74 299.15 122.58 (40.98%)
var_size_expr_evaluator q03 2077.71 2073.31 4.40 (0.21%)
var_size_expr_evaluator q04 2195.68 2212.19 -16.51 (-0.75%)
var_size_expr_evaluator q05 2661.75 2644.54 17.21 (0.65%)
var_size_expr_evaluator q06 1330.96 1329.93 1.03 (0.08%)
var_size_seq_scan q19 1455.01 1470.74 -15.73 (-1.07%)
var_size_seq_scan q20 2500.70 2772.24 -271.54 (-9.80%)
var_size_seq_scan q21 2306.83 2392.45 -85.62 (-3.58%)
var_size_seq_scan q22 127.87 125.08 2.79 (2.23%)

@github-actions

github-actions Bot commented Feb 20, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 5d4664a3ab56fe0ab5138c57cb691919a5a943d2
Branch commit hash: 85681adcee12d952892207f550eace16e543ab2f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 743.68 749.70 -6.02 (-0.80%)
aggregation q28 6333.61 6350.84 -17.23 (-0.27%)
filter q14 143.56 126.59 16.97 (13.41%)
filter q15 142.91 124.16 18.75 (15.10%)
filter q16 321.33 303.01 18.33 (6.05%)
filter q17 466.95 445.02 21.93 (4.93%)
filter q18 1983.39 1907.60 75.78 (3.97%)
filter zonemap-node 105.23 88.54 16.69 (18.85%)
filter zonemap-node-lhs-cast 104.81 88.50 16.30 (18.42%)
filter zonemap-node-null 104.86 89.10 15.76 (17.69%)
filter zonemap-rel 6915.77 5875.69 1040.08 (17.70%)
fixed_size_expr_evaluator q07 599.17 574.78 24.39 (4.24%)
fixed_size_expr_evaluator q08 819.74 801.99 17.75 (2.21%)
fixed_size_expr_evaluator q09 831.82 803.32 28.50 (3.55%)
fixed_size_expr_evaluator q10 257.40 238.23 19.16 (8.04%)
fixed_size_expr_evaluator q11 250.00 231.14 18.87 (8.16%)
fixed_size_expr_evaluator q12 247.59 230.35 17.24 (7.48%)
fixed_size_expr_evaluator q13 1485.78 1457.74 28.04 (1.92%)
fixed_size_seq_scan q23 126.82 111.83 14.99 (13.41%)
join q29 733.46 762.87 -29.41 (-3.85%)
join q30 10320.52 10295.31 25.20 (0.24%)
join q31 6.08 5.87 0.21 (3.58%)
join SelectiveTwoHopJoin 50.96 50.39 0.57 (1.13%)
ldbc_snb_ic q35 2691.38 2644.13 47.25 (1.79%)
ldbc_snb_ic q36 441.72 475.83 -34.11 (-7.17%)
ldbc_snb_is q32 5.48 5.08 0.41 (7.97%)
ldbc_snb_is q33 9.35 15.06 -5.71 (-37.93%)
ldbc_snb_is q34 1.18 1.23 -0.06 (-4.62%)
multi-rel multi-rel-large-scan 1643.25 1333.51 309.74 (23.23%)
multi-rel multi-rel-lookup 21.01 5.96 15.05 (252.32%)
multi-rel multi-rel-small-scan 80.88 96.57 -15.69 (-16.25%)
order_by q25 149.07 130.82 18.25 (13.95%)
order_by q26 469.26 461.87 7.39 (1.60%)
order_by q27 1430.85 1413.91 16.94 (1.20%)
recursive_join recursive-join-bidirection 333.74 308.53 25.21 (8.17%)
recursive_join recursive-join-dense 7032.32 7028.94 3.38 (0.05%)
recursive_join recursive-join-path 23194.39 22924.81 269.58 (1.18%)
recursive_join recursive-join-sparse 1061.40 1057.58 3.82 (0.36%)
recursive_join recursive-join-trail 6987.80 6973.31 14.48 (0.21%)
scan_after_filter q01 191.74 172.24 19.50 (11.32%)
scan_after_filter q02 174.45 156.52 17.93 (11.46%)
shortest_path_ldbc100 q37 98.14 98.56 -0.43 (-0.43%)
shortest_path_ldbc100 q38 381.65 370.24 11.41 (3.08%)
shortest_path_ldbc100 q39 67.61 65.89 1.72 (2.61%)
shortest_path_ldbc100 q40 363.12 440.03 -76.91 (-17.48%)
var_size_expr_evaluator q03 2115.99 2107.24 8.74 (0.41%)
var_size_expr_evaluator q04 2265.76 2222.64 43.12 (1.94%)
var_size_expr_evaluator q05 2704.83 2642.76 62.07 (2.35%)
var_size_expr_evaluator q06 1379.32 1328.61 50.71 (3.82%)
var_size_seq_scan q19 1493.73 1472.43 21.30 (1.45%)
var_size_seq_scan q20 2537.78 2539.02 -1.24 (-0.05%)
var_size_seq_scan q21 2328.94 2319.27 9.67 (0.42%)
var_size_seq_scan q22 132.91 126.05 6.87 (5.45%)

@ray6080
ray6080 self-requested a review February 21, 2025 16:13
@andyfengHKU
andyfengHKU merged commit aa01fdb into master Feb 25, 2025
@andyfengHKU
andyfengHKU deleted the refactor-semi-mask branch February 25, 2025 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@benjaminwinger benjaminwinger Awaiting requested review from benjaminwinger benjaminwinger is a code owner
1 more reviewer
@ray6080 ray6080 ray6080 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyfengHKU @ray6080