Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Unify vector index, gds & table function planning - #5067

Merged
andyfengHKU merged 2 commits into
masterfrom
xiyang-clean-table-func
Mar 18, 2025
Merged

Unify vector index, gds & table function planning#5067
andyfengHKU merged 2 commits into
masterfrom
xiyang-clean-table-func

Conversation

@andyfengHKU

@andyfengHKU andyfengHKU commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Description

Extract common planning logic shared by vector index, gds & table functions.

@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: b39baff6ef2497f57308ae9338dcf999d4241886
Branch commit hash: 026c83a2be063c673d7fdf280deace903d3bd47b

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 717.86 734.57 -16.71 (-2.28%)
aggregation q28 6551.40 6601.09 -49.69 (-0.75%)
filter q14 116.22 133.34 -17.13 (-12.84%)
filter q15 117.53 137.01 -19.48 (-14.22%)
filter q16 333.19 350.05 -16.86 (-4.82%)
filter q17 436.16 454.05 -17.89 (-3.94%)
filter q18 2018.01 1995.75 22.26 (1.12%)
filter zonemap-node 80.79 96.68 -15.89 (-16.44%)
filter zonemap-node-lhs-cast 80.61 96.59 -15.98 (-16.54%)
filter zonemap-node-null 80.42 96.82 -16.40 (-16.94%)
filter zonemap-rel 5652.53 5598.35 54.18 (0.97%)
fixed_size_expr_evaluator q07 678.77 692.07 -13.30 (-1.92%)
fixed_size_expr_evaluator q08 965.68 977.52 -11.84 (-1.21%)
fixed_size_expr_evaluator q09 968.61 972.75 -4.14 (-0.43%)
fixed_size_expr_evaluator q10 255.67 268.34 -12.67 (-4.72%)
fixed_size_expr_evaluator q11 253.90 269.16 -15.26 (-5.67%)
fixed_size_expr_evaluator q12 232.58 247.98 -15.40 (-6.21%)
fixed_size_expr_evaluator q13 1566.10 1573.59 -7.50 (-0.48%)
fixed_size_seq_scan q23 115.50 128.95 -13.45 (-10.43%)
join q29 704.95 732.66 -27.71 (-3.78%)
join q30 1564.15 1648.48 -84.33 (-5.12%)
join q31 4.84 8.02 -3.18 (-39.64%)
join SelectiveTwoHopJoin 48.58 45.52 3.06 (6.72%)
ldbc_snb_ic q35 10.16 10.40 -0.24 (-2.26%)
ldbc_snb_ic q36 99.27 86.27 12.99 (15.06%)
ldbc_snb_is q32 4.29 5.30 -1.02 (-19.16%)
ldbc_snb_is q33 12.78 12.63 0.15 (1.18%)
ldbc_snb_is q34 1.20 1.25 -0.04 (-3.61%)
multi-rel multi-rel-large-scan 1718.08 1671.33 46.74 (2.80%)
multi-rel multi-rel-lookup 9.90 11.10 -1.20 (-10.80%)
multi-rel multi-rel-small-scan 210.82 205.43 5.39 (2.62%)
order_by q25 120.85 136.18 -15.33 (-11.25%)
order_by q26 437.83 456.45 -18.62 (-4.08%)
order_by q27 1371.26 1434.19 -62.93 (-4.39%)
recursive_join recursive-join-bidirection 288.22 304.66 -16.44 (-5.40%)
recursive_join recursive-join-dense 7168.44 7183.06 -14.61 (-0.20%)
recursive_join recursive-join-path 23253.48 23294.62 -41.14 (-0.18%)
recursive_join recursive-join-sparse 630.59 631.58 -0.99 (-0.16%)
recursive_join recursive-join-trail 7041.70 7081.73 -40.03 (-0.57%)
scan_after_filter q01 163.52 177.69 -14.17 (-7.98%)
scan_after_filter q02 148.08 162.47 -14.39 (-8.86%)
shortest_path_ldbc100 q37 92.94 87.01 5.92 (6.81%)
shortest_path_ldbc100 q38 317.88 334.53 -16.65 (-4.98%)
shortest_path_ldbc100 q39 59.63 60.16 -0.53 (-0.89%)
shortest_path_ldbc100 q40 388.75 391.44 -2.69 (-0.69%)
var_size_expr_evaluator q03 2102.88 2108.42 -5.54 (-0.26%)
var_size_expr_evaluator q04 2303.77 2300.73 3.04 (0.13%)
var_size_expr_evaluator q05 2663.21 2750.97 -87.76 (-3.19%)
var_size_expr_evaluator q06 1347.97 1353.59 -5.62 (-0.42%)
var_size_seq_scan q19 1422.04 1452.29 -30.25 (-2.08%)
var_size_seq_scan q20 2673.31 2615.54 57.77 (2.21%)
var_size_seq_scan q21 2233.98 2237.68 -3.70 (-0.17%)
var_size_seq_scan q22 124.55 126.29 -1.74 (-1.38%)

@andyfengHKU
andyfengHKU force-pushed the xiyang-clean-table-func branch from fe09922 to ac0e389 Compare March 18, 2025 09:34
@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: b39baff6ef2497f57308ae9338dcf999d4241886
Branch commit hash: 2ecbaa61c7c547f7c4f093924b56198321129253

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 717.74 734.57 -16.84 (-2.29%)
aggregation q28 6563.39 6601.09 -37.70 (-0.57%)
filter q14 119.10 133.34 -14.24 (-10.68%)
filter q15 120.40 137.01 -16.61 (-12.13%)
filter q16 333.49 350.05 -16.56 (-4.73%)
filter q17 437.57 454.05 -16.48 (-3.63%)
filter q18 1970.68 1995.75 -25.07 (-1.26%)
filter zonemap-node 81.47 96.68 -15.20 (-15.73%)
filter zonemap-node-lhs-cast 82.53 96.59 -14.06 (-14.56%)
filter zonemap-node-null 82.75 96.82 -14.07 (-14.53%)
filter zonemap-rel 5637.65 5598.35 39.31 (0.70%)
fixed_size_expr_evaluator q07 681.94 692.07 -10.13 (-1.46%)
fixed_size_expr_evaluator q08 968.39 977.52 -9.13 (-0.93%)
fixed_size_expr_evaluator q09 967.74 972.75 -5.02 (-0.52%)
fixed_size_expr_evaluator q10 251.75 268.34 -16.59 (-6.18%)
fixed_size_expr_evaluator q11 252.41 269.16 -16.75 (-6.22%)
fixed_size_expr_evaluator q12 230.95 247.98 -17.03 (-6.87%)
fixed_size_expr_evaluator q13 1567.08 1573.59 -6.51 (-0.41%)
fixed_size_seq_scan q23 114.08 128.95 -14.87 (-11.53%)
join q29 756.66 732.66 24.00 (3.28%)
join q30 1719.69 1648.48 71.21 (4.32%)
join q31 3.80 8.02 -4.22 (-52.65%)
join SelectiveTwoHopJoin 44.32 45.52 -1.20 (-2.64%)
ldbc_snb_ic q35 7.60 10.40 -2.80 (-26.92%)
ldbc_snb_ic q36 99.19 86.27 12.92 (14.98%)
ldbc_snb_is q32 5.41 5.30 0.11 (2.05%)
ldbc_snb_is q33 12.51 12.63 -0.11 (-0.90%)
ldbc_snb_is q34 1.27 1.25 0.02 (1.52%)
multi-rel multi-rel-large-scan 1704.56 1671.33 33.23 (1.99%)
multi-rel multi-rel-lookup 9.37 11.10 -1.73 (-15.60%)
multi-rel multi-rel-small-scan 204.09 205.43 -1.34 (-0.65%)
order_by q25 127.45 136.18 -8.72 (-6.41%)
order_by q26 439.36 456.45 -17.09 (-3.74%)
order_by q27 1372.57 1434.19 -61.62 (-4.30%)
recursive_join recursive-join-bidirection 287.26 304.66 -17.40 (-5.71%)
recursive_join recursive-join-dense 7176.79 7183.06 -6.27 (-0.09%)
recursive_join recursive-join-path 23123.83 23294.62 -170.80 (-0.73%)
recursive_join recursive-join-sparse 629.11 631.58 -2.46 (-0.39%)
recursive_join recursive-join-trail 7054.87 7081.73 -26.86 (-0.38%)
scan_after_filter q01 160.07 177.69 -17.62 (-9.91%)
scan_after_filter q02 146.19 162.47 -16.28 (-10.02%)
shortest_path_ldbc100 q37 91.45 87.01 4.44 (5.10%)
shortest_path_ldbc100 q38 316.54 334.53 -18.00 (-5.38%)
shortest_path_ldbc100 q39 59.61 60.16 -0.55 (-0.91%)
shortest_path_ldbc100 q40 382.15 391.44 -9.29 (-2.37%)
var_size_expr_evaluator q03 2095.07 2108.42 -13.35 (-0.63%)
var_size_expr_evaluator q04 2307.46 2300.73 6.73 (0.29%)
var_size_expr_evaluator q05 2653.56 2750.97 -97.41 (-3.54%)
var_size_expr_evaluator q06 1350.89 1353.59 -2.70 (-0.20%)
var_size_seq_scan q19 1421.02 1452.29 -31.27 (-2.15%)
var_size_seq_scan q20 2635.96 2615.54 20.42 (0.78%)
var_size_seq_scan q21 2234.20 2237.68 -3.48 (-0.16%)
var_size_seq_scan q22 124.04 126.29 -2.25 (-1.78%)

@ray6080
ray6080 self-requested a review March 18, 2025 14:24
@andyfengHKU
andyfengHKU merged commit c6f8828 into master Mar 18, 2025
@andyfengHKU
andyfengHKU deleted the xiyang-clean-table-func branch March 18, 2025 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ray6080 ray6080 Awaiting requested review from ray6080
1 more reviewer
@acquamarin acquamarin acquamarin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyfengHKU @acquamarin