This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Add projected graph with table droping tests - #5073
Merged
Merged
Conversation
Benchmark ResultMaster commit hash:
|
ray6080
approved these changes
Mar 19, 2025
| #include "storage/index/hnsw_index_utils.h" | ||
| #include "storage/index/index_utils.h" | ||
| #include "storage/storage_manager.h" | ||
| #include <function/gds/gds.h> |
Contributor
There was a problem hiding this comment.
Suggested change
| #include <function/gds/gds.h> | |
| #include "function/gds/gds.h" |
|
|
||
| catalog::NodeTableCatalogEntry* nodeTableEntry = nullptr; | ||
| const graph::GraphEntry* graphEntry = nullptr; | ||
| // const graph::GraphEntry* graphEntry = nullptr; |
| return bindGraphEntry(context, context.getGraphEntrySetUnsafe().getEntry(name)); | ||
| } | ||
|
|
||
| GraphEntry GDSFunction::bindGraphEntry(ClientContext& context, const ParsedGraphEntry& entry) { |
Contributor
There was a problem hiding this comment.
Should this be part of GDSFunction? I don't think hnsw should be aware of gds function. Consider moving it to a common class that both gds and hnsw share.
Contributor
There was a problem hiding this comment.
Can you add one more test that a table was dropped, but then another table was created with the same name but not satisfying the requirement of a projected graph?
andyfengHKU
force-pushed
the
add-projected-graph-tx-tests
branch
from
March 20, 2025 06:33
0ca6626 to
519e569
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
force-pushed
the
add-projected-graph-tx-tests
branch
from
March 20, 2025 07:15
1cd3bb6 to
364df19
Compare
Benchmark ResultMaster commit hash:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throw proper error message if any table from projected graph is dropped afterwards. We now store a string version when creating projected graph and on-the-fly bind it for any gds/vector index query.