Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Refactor gds output writer - #5028

Merged
andyfengHKU merged 1 commit into
masterfrom
refactor-gds-output-writer
Mar 11, 2025
Merged

Refactor gds output writer#5028
andyfengHKU merged 1 commit into
masterfrom
refactor-gds-output-writer

Conversation

@andyfengHKU

@andyfengHKU andyfengHKU commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Continue to separate recursive extend and gds. Remove GDSOutputWriter as an abstraction level.

@andyfengHKU
andyfengHKU force-pushed the refactor-gds-output-writer branch from 8b0e8cd to 6529d5e Compare March 11, 2025 08:15
@github-actions

github-actions Bot commented Mar 11, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 7c25727dfdb8f389f316c953a6fb984702aa73ac
Branch commit hash: 8f706b3437f6e96534149580fa415cee33ce8d7a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 718.19 726.01 -7.82 (-1.08%)
aggregation q28 6567.62 6592.92 -25.31 (-0.38%)
filter q14 116.66 125.19 -8.53 (-6.81%)
filter q15 120.40 123.13 -2.73 (-2.22%)
filter q16 333.46 342.31 -8.85 (-2.59%)
filter q17 437.60 444.98 -7.38 (-1.66%)
filter q18 2021.47 1977.52 43.94 (2.22%)
filter zonemap-node 81.66 88.81 -7.15 (-8.05%)
filter zonemap-node-lhs-cast 81.63 89.01 -7.38 (-8.29%)
filter zonemap-node-null 81.53 88.74 -7.21 (-8.13%)
filter zonemap-rel 5689.78 5760.94 -71.16 (-1.24%)
fixed_size_expr_evaluator q07 672.99 679.85 -6.86 (-1.01%)
fixed_size_expr_evaluator q08 951.88 963.18 -11.31 (-1.17%)
fixed_size_expr_evaluator q09 952.90 968.08 -15.18 (-1.57%)
fixed_size_expr_evaluator q10 245.63 253.57 -7.94 (-3.13%)
fixed_size_expr_evaluator q11 251.05 253.47 -2.42 (-0.95%)
fixed_size_expr_evaluator q12 224.59 234.97 -10.38 (-4.42%)
fixed_size_expr_evaluator q13 1555.48 1561.61 -6.13 (-0.39%)
fixed_size_seq_scan q23 105.35 110.81 -5.46 (-4.93%)
join q29 774.23 688.94 85.29 (12.38%)
join q30 1668.01 1634.03 33.98 (2.08%)
join q31 6.45 6.21 0.24 (3.93%)
join SelectiveTwoHopJoin 47.61 51.81 -4.20 (-8.10%)
ldbc_snb_ic q35 9.37 8.08 1.29 (15.95%)
ldbc_snb_ic q36 97.09 97.22 -0.14 (-0.14%)
ldbc_snb_is q32 6.00 3.70 2.30 (62.27%)
ldbc_snb_is q33 10.11 14.74 -4.63 (-31.41%)
ldbc_snb_is q34 0.96 1.22 -0.26 (-21.59%)
multi-rel multi-rel-large-scan 1441.95 1590.24 -148.29 (-9.33%)
multi-rel multi-rel-lookup 11.89 12.52 -0.63 (-5.04%)
multi-rel multi-rel-small-scan 201.49 199.68 1.81 (0.91%)
order_by q25 122.24 130.12 -7.88 (-6.06%)
order_by q26 442.54 451.93 -9.39 (-2.08%)
order_by q27 1402.95 1376.90 26.05 (1.89%)
recursive_join recursive-join-bidirection 301.09 302.17 -1.08 (-0.36%)
recursive_join recursive-join-dense 5725.45 7150.07 -1424.62 (-19.92%)
recursive_join recursive-join-path 23097.51 23264.36 -166.85 (-0.72%)
recursive_join recursive-join-sparse 629.14 634.05 -4.91 (-0.77%)
recursive_join recursive-join-trail 6294.07 7086.51 -792.44 (-11.18%)
scan_after_filter q01 160.79 170.24 -9.45 (-5.55%)
scan_after_filter q02 145.96 154.60 -8.64 (-5.59%)
shortest_path_ldbc100 q37 83.75 86.60 -2.85 (-3.30%)
shortest_path_ldbc100 q38 333.18 314.20 18.98 (6.04%)
shortest_path_ldbc100 q39 58.73 50.19 8.53 (17.00%)
shortest_path_ldbc100 q40 441.11 379.17 61.94 (16.34%)
var_size_expr_evaluator q03 2086.32 2127.16 -40.85 (-1.92%)
var_size_expr_evaluator q04 2305.34 2264.90 40.45 (1.79%)
var_size_expr_evaluator q05 2679.00 2613.26 65.74 (2.52%)
var_size_expr_evaluator q06 1331.34 1355.32 -23.98 (-1.77%)
var_size_seq_scan q19 1421.34 1428.51 -7.17 (-0.50%)
var_size_seq_scan q20 2696.52 2775.54 -79.02 (-2.85%)
var_size_seq_scan q21 2240.51 2284.70 -44.19 (-1.93%)
var_size_seq_scan q22 122.58 127.18 -4.60 (-3.62%)

@codecov

codecov Bot commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (7c25727) to head (6529d5e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/function/gds/gds_vertex_compute.h 83.33% 1 Missing ⚠️
src/function/gds/output_writer.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5028   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files        1422     1422           
  Lines       64384    64377    -7     
  Branches     7559     7559           
=======================================
- Hits        56581    56578    -3     
+ Misses       7774     7770    -4     
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andyfengHKU
andyfengHKU merged commit 77dff7f into master Mar 11, 2025
@andyfengHKU
andyfengHKU deleted the refactor-gds-output-writer branch March 11, 2025 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mewim mewim mewim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyfengHKU @mewim