Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Test framework respects 'threads' setting unless 'PARALLELISM' is set - #5282

Merged
royi-luo merged 2 commits into
masterfrom
royi/test-threads-fix
Apr 25, 2025
Merged

Test framework respects 'threads' setting unless 'PARALLELISM' is set#5282
royi-luo merged 2 commits into
masterfrom
royi/test-threads-fix

Conversation

@royi-luo

@royi-luo royi-luo commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Description

We were resetting the test parallelism to 4 before executing each statement, this PR updates it so that the parallelism is only force-updated if the PARALLELISM token is specified in the test

Contributor agreement

@royi-luo
royi-luo requested a review from ray6080 April 25, 2025 15:26
@codecov

codecov Bot commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (8ae6727) to head (531c633).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5282      +/-   ##
==========================================
- Coverage   86.57%   86.57%   -0.01%     
==========================================
  Files        1410     1410              
  Lines       61953    61952       -1     
  Branches     7609     7606       -3     
==========================================
- Hits        53637    53634       -3     
- Misses       8141     8143       +2     
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 25, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 8ae6727cf8abae8d9e0ca8c53e9754c595a2b2c6
Branch commit hash: f7788bb2f20a7f94042eb7bd3fb4cd32f43dea53

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 729.61 904.03 -174.42 (-19.29%)
aggregation q28 6584.57 6553.95 30.62 (0.47%)
copy node-Comment 66590.94 N/A N/A
copy node-Forum 5814.02 N/A N/A
copy node-Organisation 1286.37 N/A N/A
copy node-Person 2200.53 N/A N/A
copy node-Place 1219.65 N/A N/A
copy node-Post 28810.95 N/A N/A
copy node-Tag 1365.33 N/A N/A
copy node-Tagclass 1237.66 N/A N/A
copy rel-comment-hasCreator 55117.66 N/A N/A
copy rel-comment-hasTag 76493.16 N/A N/A
copy rel-comment-isLocatedIn 60633.89 N/A N/A
copy rel-containerOf 15070.94 N/A N/A
copy rel-forum-hasTag 3748.47 N/A N/A
copy rel-hasInterest 2646.13 N/A N/A
copy rel-hasMember 48330.67 N/A N/A
copy rel-hasModerator 1336.59 N/A N/A
copy rel-hasType 336.74 N/A N/A
copy rel-isPartOf 338.85 N/A N/A
copy rel-isSubclassOf 342.23 N/A N/A
copy rel-knows 5993.20 N/A N/A
copy rel-likes-comment 83527.26 N/A N/A
copy rel-likes-post 32785.80 N/A N/A
copy rel-organisation-isLocatedIn 382.06 N/A N/A
copy rel-person-isLocatedIn 563.69 N/A N/A
copy rel-post-hasCreator 14033.50 N/A N/A
copy rel-post-hasTag 20684.05 N/A N/A
copy rel-post-isLocatedIn 17533.50 N/A N/A
copy rel-replyOf-comment 51763.57 N/A N/A
copy rel-replyOf-post 41194.80 N/A N/A
copy rel-studyAt 617.23 N/A N/A
copy rel-workAt 819.24 N/A N/A
filter q14 124.44 127.25 -2.81 (-2.21%)
filter q15 126.02 126.88 -0.86 (-0.68%)
filter q16 339.33 341.36 -2.03 (-0.59%)
filter q17 445.92 445.88 0.04 (0.01%)
filter q18 1932.27 1944.84 -12.58 (-0.65%)
filter zonemap-node 89.39 88.23 1.17 (1.32%)
filter zonemap-node-lhs-cast 88.04 88.50 -0.46 (-0.52%)
filter zonemap-node-null 88.25 88.75 -0.49 (-0.55%)
filter zonemap-rel 5812.84 5809.76 3.08 (0.05%)
fixed_size_expr_evaluator q07 678.92 682.52 -3.60 (-0.53%)
fixed_size_expr_evaluator q08 965.16 962.41 2.75 (0.29%)
fixed_size_expr_evaluator q09 972.49 962.59 9.90 (1.03%)
fixed_size_expr_evaluator q10 254.80 256.63 -1.83 (-0.71%)
fixed_size_expr_evaluator q11 254.96 255.15 -0.19 (-0.07%)
fixed_size_expr_evaluator q12 232.47 234.42 -1.96 (-0.83%)
fixed_size_expr_evaluator q13 1600.82 1609.40 -8.58 (-0.53%)
fixed_size_seq_scan q23 110.56 111.19 -0.63 (-0.57%)
join q29 723.76 695.01 28.74 (4.14%)
join q30 1584.85 1538.54 46.30 (3.01%)
join q31 5.63 4.67 0.96 (20.67%)
join SelectiveTwoHopJoin 51.50 46.61 4.88 (10.47%)
ldbc_snb_ic q35 10.74 9.90 0.84 (8.48%)
ldbc_snb_ic q36 92.09 97.16 -5.06 (-5.21%)
ldbc_snb_is q32 3.47 5.96 -2.49 (-41.73%)
ldbc_snb_is q33 10.23 15.91 -5.69 (-35.73%)
ldbc_snb_is q34 1.33 1.28 0.05 (3.85%)
limit push-down-limit-into-distinct 2105.53 2081.40 24.13 (1.16%)
multi-rel multi-rel-large-scan 1671.93 1716.36 -44.43 (-2.59%)
multi-rel multi-rel-lookup 12.04 11.47 0.56 (4.92%)
multi-rel multi-rel-small-scan 200.59 201.00 -0.41 (-0.21%)
order_by q25 130.38 130.40 -0.02 (-0.02%)
order_by q26 446.01 445.45 0.57 (0.13%)
order_by q27 1413.78 1407.16 6.62 (0.47%)
recursive_join recursive-join-bidirection 341.51 359.72 -18.21 (-5.06%)
recursive_join recursive-join-dense 7022.60 7044.57 -21.97 (-0.31%)
recursive_join recursive-join-path 23215.89 23012.20 203.69 (0.89%)
recursive_join recursive-join-sparse 7.31 12.91 -5.60 (-43.37%)
recursive_join recursive-join-trail 6978.30 6980.55 -2.25 (-0.03%)
scan_after_filter q01 169.70 168.99 0.71 (0.42%)
scan_after_filter q02 155.49 155.04 0.45 (0.29%)
shortest_path_ldbc100 q37 81.19 90.10 -8.90 (-9.88%)
shortest_path_ldbc100 q38 701.43 775.42 -73.99 (-9.54%)
shortest_path_ldbc100 q39 92.39 84.91 7.48 (8.81%)
shortest_path_ldbc100 q40 821.93 811.60 10.34 (1.27%)
var_size_expr_evaluator q03 2089.59 2070.09 19.50 (0.94%)
var_size_expr_evaluator q04 2222.73 2224.69 -1.96 (-0.09%)
var_size_expr_evaluator q05 2682.65 2659.50 23.15 (0.87%)
var_size_expr_evaluator q06 1360.59 1348.96 11.63 (0.86%)
var_size_seq_scan q19 1411.04 1430.60 -19.57 (-1.37%)
var_size_seq_scan q20 2809.18 2801.66 7.52 (0.27%)
var_size_seq_scan q21 2256.91 2258.30 -1.39 (-0.06%)
var_size_seq_scan q22 124.68 125.75 -1.07 (-0.85%)

@royi-luo
royi-luo merged commit 62d21db into master Apr 25, 2025
@royi-luo
royi-luo deleted the royi/test-threads-fix branch April 25, 2025 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ray6080 ray6080 ray6080 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@royi-luo @ray6080