Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

expedite clang tidy check - #5208

Merged
acquamarin merged 8 commits into
masterfrom
fix-clang
Apr 9, 2025
Merged

expedite clang tidy check#5208
acquamarin merged 8 commits into
masterfrom
fix-clang

Conversation

@acquamarin

@acquamarin acquamarin commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (fd6ac8d) to head (ab7403d).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5208   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files        1405     1405           
  Lines       61622    61629    +7     
  Branches     7543     7540    -3     
=======================================
+ Hits        53594    53601    +7     
- Misses       7854     7855    +1     
+ Partials      174      173    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: fd6ac8d83498bd09ba7cde0aedced867afbd1db4
Branch commit hash: 07d9fce9b6a096d09c7fda2667d7c48d7a90c5fe

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 723.42 725.55 -2.13 (-0.29%)
aggregation q28 6479.01 6483.69 -4.68 (-0.07%)
filter q14 125.20 125.91 -0.71 (-0.57%)
filter q15 125.46 121.60 3.85 (3.17%)
filter q16 341.24 343.84 -2.60 (-0.76%)
filter q17 448.38 446.00 2.38 (0.53%)
filter q18 1895.41 1901.36 -5.94 (-0.31%)
filter zonemap-node 88.44 88.75 -0.31 (-0.35%)
filter zonemap-node-lhs-cast 88.83 89.17 -0.34 (-0.38%)
filter zonemap-node-null 88.70 88.61 0.09 (0.10%)
filter zonemap-rel 5459.23 5322.62 136.61 (2.57%)
fixed_size_expr_evaluator q07 679.37 678.66 0.71 (0.10%)
fixed_size_expr_evaluator q08 963.69 964.34 -0.65 (-0.07%)
fixed_size_expr_evaluator q09 960.46 959.23 1.24 (0.13%)
fixed_size_expr_evaluator q10 254.22 253.94 0.28 (0.11%)
fixed_size_expr_evaluator q11 255.22 255.11 0.11 (0.04%)
fixed_size_expr_evaluator q12 233.88 232.77 1.11 (0.47%)
fixed_size_expr_evaluator q13 1561.46 1567.36 -5.90 (-0.38%)
fixed_size_seq_scan q23 118.59 112.81 5.78 (5.13%)
join q29 697.52 698.13 -0.61 (-0.09%)
join q30 1636.76 1576.50 60.26 (3.82%)
join q31 5.47 4.33 1.14 (26.27%)
join SelectiveTwoHopJoin 51.50 42.05 9.45 (22.47%)
ldbc_snb_ic q35 9.29 10.83 -1.54 (-14.21%)
ldbc_snb_ic q36 80.92 99.82 -18.90 (-18.93%)
ldbc_snb_is q32 4.90 6.25 -1.35 (-21.58%)
ldbc_snb_is q33 13.02 13.24 -0.21 (-1.62%)
ldbc_snb_is q34 1.25 1.28 -0.03 (-2.39%)
multi-rel multi-rel-large-scan 1731.03 1725.36 5.67 (0.33%)
multi-rel multi-rel-lookup 11.55 11.59 -0.04 (-0.36%)
multi-rel multi-rel-small-scan 207.70 189.32 18.38 (9.71%)
order_by q25 132.74 131.03 1.71 (1.31%)
order_by q26 448.19 448.12 0.08 (0.02%)
order_by q27 1393.43 1392.45 0.98 (0.07%)
recursive_join recursive-join-bidirection 293.96 290.23 3.72 (1.28%)
recursive_join recursive-join-dense 7050.88 7036.75 14.14 (0.20%)
recursive_join recursive-join-path 23044.84 23312.03 -267.20 (-1.15%)
recursive_join recursive-join-sparse 635.06 631.92 3.14 (0.50%)
recursive_join recursive-join-trail 7002.23 6994.60 7.63 (0.11%)
scan_after_filter q01 168.32 168.09 0.23 (0.13%)
scan_after_filter q02 154.88 153.58 1.30 (0.85%)
shortest_path_ldbc100 q37 87.60 83.32 4.28 (5.13%)
shortest_path_ldbc100 q38 344.55 281.85 62.70 (22.24%)
shortest_path_ldbc100 q39 60.16 62.24 -2.08 (-3.34%)
shortest_path_ldbc100 q40 399.06 338.04 61.03 (18.05%)
var_size_expr_evaluator q03 2111.78 2114.65 -2.87 (-0.14%)
var_size_expr_evaluator q04 2203.50 2206.17 -2.67 (-0.12%)
var_size_expr_evaluator q05 2681.16 2682.23 -1.07 (-0.04%)
var_size_expr_evaluator q06 1363.83 1355.14 8.69 (0.64%)
var_size_seq_scan q19 1441.88 1439.01 2.87 (0.20%)
var_size_seq_scan q20 2279.73 2357.12 -77.39 (-3.28%)
var_size_seq_scan q21 2251.56 2267.05 -15.49 (-0.68%)
var_size_seq_scan q22 126.80 126.04 0.75 (0.60%)

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 73b7ba9c061c4a02b90e335d07d934cb83f4d01e
Branch commit hash: f65495144a2ce9d1e26d299796ddb75a480c6469

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 725.68 724.54 1.14 (0.16%)
aggregation q28 6475.37 6533.81 -58.44 (-0.89%)
filter q14 127.99 130.04 -2.05 (-1.58%)
filter q15 121.54 122.48 -0.94 (-0.77%)
filter q16 343.88 343.96 -0.08 (-0.02%)
filter q17 444.06 445.60 -1.54 (-0.34%)
filter q18 1899.44 1902.19 -2.75 (-0.14%)
filter zonemap-node 88.86 90.14 -1.29 (-1.43%)
filter zonemap-node-lhs-cast 88.57 89.07 -0.51 (-0.57%)
filter zonemap-node-null 88.16 89.15 -0.99 (-1.11%)
filter zonemap-rel 5660.42 5513.31 147.11 (2.67%)
fixed_size_expr_evaluator q07 680.38 677.36 3.02 (0.45%)
fixed_size_expr_evaluator q08 959.76 959.94 -0.18 (-0.02%)
fixed_size_expr_evaluator q09 961.88 960.03 1.85 (0.19%)
fixed_size_expr_evaluator q10 255.97 254.75 1.22 (0.48%)
fixed_size_expr_evaluator q11 258.22 254.65 3.57 (1.40%)
fixed_size_expr_evaluator q12 234.52 232.54 1.98 (0.85%)
fixed_size_expr_evaluator q13 1568.14 1566.38 1.76 (0.11%)
fixed_size_seq_scan q23 117.76 112.24 5.52 (4.92%)
join q29 699.49 756.61 -57.12 (-7.55%)
join q30 1616.50 1704.24 -87.74 (-5.15%)
join q31 6.04 5.49 0.55 (10.06%)
join SelectiveTwoHopJoin 54.22 46.52 7.70 (16.55%)
ldbc_snb_ic q35 10.61 10.99 -0.38 (-3.46%)
ldbc_snb_ic q36 107.22 95.26 11.96 (12.55%)
ldbc_snb_is q32 3.94 5.09 -1.16 (-22.68%)
ldbc_snb_is q33 14.94 11.81 3.14 (26.55%)
ldbc_snb_is q34 1.20 1.27 -0.08 (-6.22%)
multi-rel multi-rel-large-scan 1688.04 1695.99 -7.95 (-0.47%)
multi-rel multi-rel-lookup 10.21 9.95 0.26 (2.65%)
multi-rel multi-rel-small-scan 210.31 201.54 8.77 (4.35%)
order_by q25 128.59 130.77 -2.18 (-1.67%)
order_by q26 448.57 453.02 -4.44 (-0.98%)
order_by q27 1394.55 1389.29 5.26 (0.38%)
recursive_join recursive-join-bidirection 310.33 305.88 4.45 (1.46%)
recursive_join recursive-join-dense 7014.75 7012.69 2.06 (0.03%)
recursive_join recursive-join-path 23157.92 23128.21 29.72 (0.13%)
recursive_join recursive-join-sparse 636.12 635.99 0.13 (0.02%)
recursive_join recursive-join-trail 7013.54 7034.77 -21.22 (-0.30%)
scan_after_filter q01 168.58 169.92 -1.34 (-0.79%)
scan_after_filter q02 154.79 155.83 -1.05 (-0.67%)
shortest_path_ldbc100 q37 95.20 95.97 -0.77 (-0.81%)
shortest_path_ldbc100 q38 330.98 320.49 10.49 (3.27%)
shortest_path_ldbc100 q39 59.53 51.00 8.53 (16.72%)
shortest_path_ldbc100 q40 423.00 358.82 64.18 (17.89%)
var_size_expr_evaluator q03 2108.95 2125.28 -16.33 (-0.77%)
var_size_expr_evaluator q04 2208.71 2207.32 1.39 (0.06%)
var_size_expr_evaluator q05 2688.06 2689.02 -0.95 (-0.04%)
var_size_expr_evaluator q06 1355.10 1361.26 -6.15 (-0.45%)
var_size_seq_scan q19 1444.55 1439.80 4.75 (0.33%)
var_size_seq_scan q20 2469.48 2467.02 2.46 (0.10%)
var_size_seq_scan q21 2248.82 2245.69 3.13 (0.14%)
var_size_seq_scan q22 126.04 125.67 0.37 (0.29%)

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: 73b7ba9c061c4a02b90e335d07d934cb83f4d01e
Branch commit hash: 2a10755e38e1770edf87920b61b67b58e9ef0205

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 726.90 724.54 2.37 (0.33%)
aggregation q28 6546.41 6533.81 12.60 (0.19%)
filter q14 125.34 130.04 -4.70 (-3.61%)
filter q15 127.87 122.48 5.39 (4.40%)
filter q16 343.64 343.96 -0.33 (-0.09%)
filter q17 446.49 445.60 0.89 (0.20%)
filter q18 1891.54 1902.19 -10.64 (-0.56%)
filter zonemap-node 89.58 90.14 -0.56 (-0.62%)
filter zonemap-node-lhs-cast 89.59 89.07 0.52 (0.58%)
filter zonemap-node-null 88.72 89.15 -0.43 (-0.48%)
filter zonemap-rel 5596.00 5513.31 82.69 (1.50%)
fixed_size_expr_evaluator q07 680.36 677.36 3.00 (0.44%)
fixed_size_expr_evaluator q08 963.64 959.94 3.70 (0.39%)
fixed_size_expr_evaluator q09 961.76 960.03 1.74 (0.18%)
fixed_size_expr_evaluator q10 253.64 254.75 -1.11 (-0.44%)
fixed_size_expr_evaluator q11 254.41 254.65 -0.24 (-0.10%)
fixed_size_expr_evaluator q12 232.52 232.54 -0.02 (-0.01%)
fixed_size_expr_evaluator q13 1568.75 1566.38 2.37 (0.15%)
fixed_size_seq_scan q23 111.07 112.24 -1.17 (-1.04%)
join q29 731.55 756.61 -25.05 (-3.31%)
join q30 1559.29 1704.24 -144.95 (-8.51%)
join q31 5.11 5.49 -0.38 (-6.93%)
join SelectiveTwoHopJoin 45.44 46.52 -1.08 (-2.32%)
ldbc_snb_ic q35 10.56 10.99 -0.42 (-3.87%)
ldbc_snb_ic q36 93.09 95.26 -2.17 (-2.28%)
ldbc_snb_is q32 6.90 5.09 1.81 (35.52%)
ldbc_snb_is q33 15.23 11.81 3.42 (28.95%)
ldbc_snb_is q34 1.23 1.27 -0.04 (-3.40%)
multi-rel multi-rel-large-scan 1716.63 1695.99 20.64 (1.22%)
multi-rel multi-rel-lookup 10.03 9.95 0.09 (0.86%)
multi-rel multi-rel-small-scan 202.15 201.54 0.61 (0.30%)
order_by q25 133.09 130.77 2.32 (1.78%)
order_by q26 451.00 453.02 -2.01 (-0.44%)
order_by q27 1390.47 1389.29 1.17 (0.08%)
recursive_join recursive-join-bidirection 287.65 305.88 -18.23 (-5.96%)
recursive_join recursive-join-dense 5824.38 7012.69 -1188.31 (-16.95%)
recursive_join recursive-join-path 23041.73 23128.21 -86.48 (-0.37%)
recursive_join recursive-join-sparse 627.48 635.99 -8.51 (-1.34%)
recursive_join recursive-join-trail 6331.48 7034.77 -703.29 (-10.00%)
scan_after_filter q01 169.95 169.92 0.03 (0.02%)
scan_after_filter q02 154.99 155.83 -0.85 (-0.55%)
shortest_path_ldbc100 q37 74.91 95.97 -21.06 (-21.95%)
shortest_path_ldbc100 q38 254.07 320.49 -66.42 (-20.72%)
shortest_path_ldbc100 q39 61.96 51.00 10.96 (21.48%)
shortest_path_ldbc100 q40 251.20 358.82 -107.63 (-29.99%)
var_size_expr_evaluator q03 2136.65 2125.28 11.37 (0.54%)
var_size_expr_evaluator q04 2211.20 2207.32 3.88 (0.18%)
var_size_expr_evaluator q05 2728.70 2689.02 39.68 (1.48%)
var_size_expr_evaluator q06 1352.32 1361.26 -8.93 (-0.66%)
var_size_seq_scan q19 1443.61 1439.80 3.80 (0.26%)
var_size_seq_scan q20 2535.54 2467.02 68.52 (2.78%)
var_size_seq_scan q21 2242.10 2245.69 -3.59 (-0.16%)
var_size_seq_scan q22 125.76 125.67 0.10 (0.08%)

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown

Benchmark Result

Master commit hash: fe12d4ff35316fbbdc2b24df74573340476ad3db
Branch commit hash: c01dabafb7716e5ee871dc46f875ba0c24218064

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 741.03 724.03 17.00 (2.35%)
aggregation q28 6568.04 6472.64 95.40 (1.47%)
filter q14 140.66 124.77 15.89 (12.74%)
filter q15 140.59 126.44 14.15 (11.19%)
filter q16 360.05 346.47 13.58 (3.92%)
filter q17 461.61 447.39 14.22 (3.18%)
filter q18 1886.63 1915.62 -28.98 (-1.51%)
filter zonemap-node 96.56 88.25 8.31 (9.42%)
filter zonemap-node-lhs-cast 96.59 88.81 7.77 (8.75%)
filter zonemap-node-null 96.33 89.74 6.59 (7.34%)
filter zonemap-rel 5561.75 5395.33 166.43 (3.08%)
fixed_size_expr_evaluator q07 696.61 678.12 18.49 (2.73%)
fixed_size_expr_evaluator q08 976.39 961.54 14.86 (1.54%)
fixed_size_expr_evaluator q09 973.24 959.47 13.77 (1.44%)
fixed_size_expr_evaluator q10 270.38 254.33 16.05 (6.31%)
fixed_size_expr_evaluator q11 270.64 255.61 15.03 (5.88%)
fixed_size_expr_evaluator q12 248.99 236.07 12.92 (5.47%)
fixed_size_expr_evaluator q13 1579.88 1560.93 18.95 (1.21%)
fixed_size_seq_scan q23 126.95 112.25 14.70 (13.09%)
join q29 704.15 738.57 -34.42 (-4.66%)
join q30 1555.79 1550.70 5.09 (0.33%)
join q31 7.81 6.04 1.78 (29.42%)
join SelectiveTwoHopJoin 47.79 54.63 -6.84 (-12.52%)
ldbc_snb_ic q35 10.32 10.84 -0.52 (-4.79%)
ldbc_snb_ic q36 101.36 93.17 8.19 (8.79%)
ldbc_snb_is q32 3.94 5.14 -1.20 (-23.32%)
ldbc_snb_is q33 14.90 12.42 2.48 (19.95%)
ldbc_snb_is q34 1.43 1.41 0.02 (1.23%)
multi-rel multi-rel-large-scan 1831.13 2031.35 -200.22 (-9.86%)
multi-rel multi-rel-lookup 11.66 12.19 -0.53 (-4.34%)
multi-rel multi-rel-small-scan 217.38 206.40 10.97 (5.32%)
order_by q25 145.42 131.46 13.96 (10.62%)
order_by q26 463.68 447.91 15.78 (3.52%)
order_by q27 1387.07 1389.76 -2.69 (-0.19%)
recursive_join recursive-join-bidirection 307.91 284.08 23.84 (8.39%)
recursive_join recursive-join-dense 7105.24 7151.56 -46.32 (-0.65%)
recursive_join recursive-join-path 23142.77 23295.72 -152.96 (-0.66%)
recursive_join recursive-join-sparse 631.18 634.91 -3.73 (-0.59%)
recursive_join recursive-join-trail 7080.98 7097.63 -16.65 (-0.23%)
scan_after_filter q01 184.63 168.21 16.42 (9.76%)
scan_after_filter q02 171.53 154.95 16.58 (10.70%)
shortest_path_ldbc100 q37 91.36 85.31 6.04 (7.09%)
shortest_path_ldbc100 q38 313.48 334.76 -21.28 (-6.36%)
shortest_path_ldbc100 q39 64.08 65.48 -1.41 (-2.15%)
shortest_path_ldbc100 q40 405.01 283.63 121.38 (42.80%)
var_size_expr_evaluator q03 2118.18 2117.62 0.56 (0.03%)
var_size_expr_evaluator q04 2181.72 2212.55 -30.83 (-1.39%)
var_size_expr_evaluator q05 2625.01 2684.49 -59.48 (-2.22%)
var_size_expr_evaluator q06 1356.30 1364.77 -8.47 (-0.62%)
var_size_seq_scan q19 1437.03 1437.37 -0.34 (-0.02%)
var_size_seq_scan q20 2533.07 2370.08 163.00 (6.88%)
var_size_seq_scan q21 2271.89 2250.91 20.98 (0.93%)
var_size_seq_scan q22 127.94 126.30 1.64 (1.30%)

@acquamarin acquamarin changed the title Try fix clang-tidy expedite clang tidy check Apr 9, 2025
@acquamarin
acquamarin merged commit 34852cc into master Apr 9, 2025
@acquamarin
acquamarin deleted the fix-clang branch April 9, 2025 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andyfengHKU andyfengHKU andyfengHKU approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acquamarin @andyfengHKU