Conversation
Signed-off-by: Schatten <czhengt@qq.com>
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 21, 2026 11:09
Aionw
approved these changes
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Complete the remaining eligible Mooncake Store environment-variable convergence tracked by #3809.
This PR introduces four component-owned configuration boundaries:
DfsEnablementConfigownsMOONCAKE_ENABLE_DFSand its legacyMOONCAKE_DFS_ENABLEDalias.MasterMetadataConfigowns theMC_METADATA_CLUSTER_IDmetadata prefix.StoreClusterIdentityConfigprovides the single Store owner forMC_STORE_CLUSTER_ID.NvmeKvExecutorConfigowns the NVMe KV alignment, block-unit, protocol-size, and read-plan batch settings.The refactor preserves the existing environment names, defaults, alias precedence, diagnostics, parsing compatibility, and read lifecycle. The NVMe values intentionally retain their existing string parsing behavior, including supported base prefixes and fallback semantics.
This owner-scoped work supersedes the remaining Mooncake Store portion of the older cross-component approach in #1538. It does not duplicate the independently scoped work in #4170, #4171, #4203, #4204, or #4245. Remaining direct environment reads belong to external accelerator contracts, Master bootstrap/Kubernetes paths, or test/failpoint/stub-only controls.
Module
mooncake-transfer-engine)mooncake-store)mooncake-conductor)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
Touched-file pre-commit hooks also pass for the changed source and test files.
Checklist
./scripts/code_format.shAI Assistance Disclosure
Codex assisted with the component-owned config extraction, unit tests, verification, and final review. The submitter reviewed the resulting changes and is responsible for them.