Repository navigation
Fix desktop typecheck failure (missing files in tsconfig.node.json) - #10
Merged
Merged
Conversation
CI's "test" job has been failing on every recent PR (unrelated to whatever that PR actually changed) with: error TS6307: File '.../src/lib/fetch-timeout.ts' is not listed within the file list of project '.../desktop/tsconfig.node.json' Both src/lib/fetch-timeout.ts and src/services/copilot/fetch-with- reauth.ts are imported by files already in this project's file list (create-responses.ts under both codex/ and copilot/), but were never themselves added to it -- TS project references require every file in the dependency graph to be explicitly listed or covered by an include pattern. Verified fix: `bun run typecheck` in desktop/ now passes clean (was failing before this change, confirmed against the exact same command CI runs). Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Responses generated with Claude
CI's
testjob has been failing on every recent PR (unrelated to whatever that PR actually changed) with:Both
src/lib/fetch-timeout.tsandsrc/services/copilot/fetch-with-reauth.tsare imported by files already in this project's file list (create-responses.tsunder bothcodex/andcopilot/), but were never themselves added to it -- TS project references require every file in the dependency graph to be explicitly listed or covered by an include pattern.Testing
Verified fix:
bun run typecheckindesktop/now passes clean (confirmed it was failing before this change, using the exact same command CI runs).