Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More help from Claude in sorting out #96.
Trade-off: returning
NaNwhen eigenvalues are tied also affects cases that happened to come out correct before. Example: a diagonal matrix perturbed only along its diagonal, passed with getNaNderivatives at exact ties. That seems the safer default, but the maintainer may prefer an option or a warning.RTMB/R/eigen.R:nan_complex(), returns a matrix of complexNaNs.solve_complex(),eigen_rescaled(), and thesolve(V)step ineigen_rescaled_adj()now returnNaNmatrices instead of raising an R error when the decomposition fails.eigen_rescaled_adj()returnsNaNderivatives when any two eigenvalues are withinsqrt(.Machine$double.eps) * max(Mod(D))of each other. Previously it silently dropped those terms.eigen_symmetric_adj)alone. It uses the same 1e-300 trick, but in that case the result is correct whenever the input perturbation doesn't mix the repeated eigenspace.RTMB/inst/tinytest/test-factorize.R: seven new tests: