Open
Conversation
katef
requested changes
Apr 27, 2018
Owner
There was a problem hiding this comment.
I think this will break for macos, because the other flags for LDFLAGS are written for ld, not cc. e.g.:
LDSFLAGS += -macosx_version_min ${MACOSX_VERSION_MIN}
for some cases gcc has an equivalent flag to pass those along (i.e. -mmacosx_version_min, with the extra m).
For -dylib -flat_namespace -undefined dynamic_lookup I haven't checked. Those could be passed along by -Wl,... but if we're calling ${CC} here I'd rather use gcc and clang's equivalent flags where they're provided.
| # | ||
|
|
||
| LD ?= ld | ||
| SOLD ?= ${CC} |
Owner
There was a problem hiding this comment.
Let's call that LDS, because it matches LDSFLAGS below
Owner
There was a problem hiding this comment.
Don't forget to update the manpages too please!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change to use ${CC} to created shared objects rather than using
lddirectly, so that the compiler driver has the opportunity to do things the way it wants them done.