Avoid duplicate search entries#43
Merged
Merged
Conversation
kayrus
requested changes
Mar 26, 2022
kayrus
left a comment
Owner
There was a problem hiding this comment.
apologies for late response. see my comments.
fwiesel
force-pushed
the
remove_duplicate_search
branch
from
March 28, 2022 12:51
6934ac9 to
46e3417
Compare
kayrus
reviewed
Mar 28, 2022
More a stilistic nicety. If we get a search suffix passed, which is already part of the local configuration, it will be duplicated. The change avoids that
fwiesel
force-pushed
the
remove_duplicate_search
branch
from
March 28, 2022 14:51
46e3417 to
d5bea10
Compare
kayrus
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More a stilistic nicety. If we get a search suffix passed,
which is already part of the local configuration, it will
be duplicated. The change avoids that