Skip to content
This repository was archived by the owner on Dec 31, 2024. It is now read-only.

feat(index): Fix #193 add availableLocales - #528

Merged
kazupon merged 7 commits into
kazupon:devfrom
exoego:list-available-languages
Mar 8, 2019
Merged

feat(index): Fix #193 add availableLocales#528
kazupon merged 7 commits into
kazupon:devfrom
exoego:list-available-languages

Conversation

@exoego

@exoego exoego commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

Closes #193

kazupon
kazupon suggested changes Mar 7, 2019
View reviewed changes

@kazupon kazupon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
I've reviewed this PR 👀

I have a request. 🙏
Could you add documentation, please?

Comment thread src/index.js Outdated
@kazupon

kazupon commented Mar 7, 2019

Copy link
Copy Markdown
Owner

and, in addition, I have one more request.
Could you add type declaration of typescript and flow, please? 🙏

@kazupon @exoego
Update src/index.js
c6f7918 
Co-Authored-By: exoego <ytatsuno.jp@gmail.com>
@codecov-io

codecov-io commented Mar 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #528 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #528      +/-   ##
==========================================
+ Coverage   96.63%   96.63%   +<.01%     
==========================================
  Files           9        9              
  Lines         683      684       +1     
==========================================
+ Hits          660      661       +1     
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396c5ca...c6f7918. Read the comment docs.

@codecov-io

codecov-io commented Mar 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #528 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #528      +/-   ##
==========================================
+ Coverage   96.63%   96.63%   +<.01%     
==========================================
  Files           9        9              
  Lines         683      684       +1     
==========================================
+ Hits          660      661       +1     
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396c5ca...ce01c68. Read the comment docs.

@exoego

exoego commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator Author

@kazupon
Docs and type definition added !!

exoego
exoego commented Mar 7, 2019
View reviewed changes
Comment thread decls/i18n.js Outdated
set fallbackLocale (locale: Locale): void,
get messages (): LocaleMessages,
get dateTimeFormats (): DateTimeFormats,
get numberFormats (): NumberFormats,

@exoego exoego Mar 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note)
I thinks numberFormats is missing and the fix is trivial, so I fixed, though it is out of scope of #193...
I can make a separate PR if it is preferrable.

@kazupon kazupon Mar 7, 2019

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you will separate it as PR. 🙏

@exoego exoego Mar 8, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

kazupon
kazupon reviewed Mar 8, 2019
View reviewed changes
Comment thread vuepress/api/README.md Outdated
@kazupon

kazupon commented Mar 8, 2019

Copy link
Copy Markdown
Owner

CI still have been failing.
Could you fix it, please?

kazupon and others added 2 commits March 8, 2019 10:41
kazupon
kazupon approved these changes Mar 8, 2019
View reviewed changes

@kazupon kazupon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank for your supporting!

@kazupon
kazupon merged commit 8f75b1f into kazupon:dev Mar 8, 2019
@rimiti

rimiti commented Mar 8, 2019

Copy link
Copy Markdown

Good job 🚀

@exoego
exoego deleted the list-available-languages branch March 8, 2019 09:03
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kazupon kazupon kazupon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@exoego @kazupon @codecov-io @rimiti